Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert for snapshotter failure in etcd-backup-restore #4094

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

aaronfern
Copy link
Contributor

How to categorize this PR?

/area monitoring
/area backup
/area high-availability
/kind enhancement

What this PR does / why we need it:
Adds an alert to monitor for any snapshotter failure in etcd-backup-restore that would affect the backup snapshots being taken or deleted.

Which issue(s) this PR fixes:
Fixes partially gardener/etcd-backup-restore#325

Special notes for your reviewer:

Release note:

Added alert to monitor for any snapshotter failure in etcd-backup-restore

@aaronfern aaronfern requested a review from a team as a code owner May 21, 2021 08:02
@gardener-robot gardener-robot added area/backup Backup related area/high-availability High availability related area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension needs/review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2021
@gardener-robot-ci-3
Copy link
Contributor

Thank you @aaronfern for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gardener-robot
Copy link

@amshuman-kr, @wyb1, @shreyas-s-rao You have pull request review open invite, please check

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/reviewed ok-to-test

/cc @stoyanr - do you think this can be added to v1.24?

@gardener-robot gardener-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 29, 2021
@rfranzke rfranzke merged commit f0c54c5 into gardener:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backup Backup related area/high-availability High availability related area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants