Vendor golang/mock@v1.6.0 #4210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a lot of DoAndReturn usages in our tests that didn't correctly use the client func signatures. With golang/mock#558 this is now validated and tests fail, if the signature of the provided func literal is not the same as the one of the real func. This commit fixes our wrong usages to comply with the newest gomock behavior.
gardener-robot
added
area/testing
|
/milestone v1.25 |
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Vendor golang/mock@v1.6.0 * Fix wrong DoAndReturn usages There were a lot of DoAndReturn usages in our tests that didn't correctly use the client func signatures. With golang/mock#558 this is now validated and tests fail, if the signature of the provided func literal is not the same as the one of the real func. This commit fixes our wrong usages to comply with the newest gomock behavior.
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Vendor golang/mock@v1.6.0 * Fix wrong DoAndReturn usages There were a lot of DoAndReturn usages in our tests that didn't correctly use the client func signatures. With golang/mock#558 this is now validated and tests fail, if the signature of the provided func literal is not the same as the one of the real func. This commit fixes our wrong usages to comply with the newest gomock behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area testing
/kind task
What this PR does / why we need it:
Vendor golang/mock@v1.6.0 and adapts our tests to the changed behavior.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
First commit is basically
go mod edit -require=github.com/golang/mock@v1.6.0 && make revendor, the second one is the actual adaption./squash
Release note: