Enable overriding the grace periods for cleanup steps in shoot deletion #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
|
/assign |
timebertt
reviewed
Jun 17, 2021
rfranzke
force-pushed
the
enh/grace-period-configuration
branch
from
3731077
to
c5c2cc6
Compare
|
/squash |
|
cc @pbochynski - you might be interested in this PR |
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
…on (gardener#4212) * Enable overriding the grace periods for cleanup steps in shoot deletion * Improve signature of getCleanOptions * Ignore grace periods larger than the defaults
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
…on (gardener#4212) * Enable overriding the grace periods for cleanup steps in shoot deletion * Improve signature of getCleanOptions * Ignore grace periods larger than the defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability ops-productivity
/kind enhancement
What this PR does / why we need it:
It's now possible to override the grace periods for the cleanup steps in the shoot deletion by specifying the following annotations on the
Shoot:shoot.gardener.cloud/cleanup-webhooks-finalize-grace-period-seconds(default behaviour:"300")shoot.gardener.cloud/cleanup-extended-apis-finalize-grace-period-seconds(default behaviour:"3600")shoot.gardener.cloud/cleanup-kubernetes-resources-finalize-grace-period-seconds(default behaviour:"300")shoot.gardener.cloud/cleanup-namespaces-finalize-grace-period-seconds(default behaviour:"300")If
"0"is provided then all resources are finalized immediately without waiting for any graceful deletion. Please be aware that this might lead to orphaned infrastructure artefacts.Which issue(s) this PR fixes:
Part 2 of #3110 (comment)
Release note: