Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small follow-ups after vendoring controller-runtime #4217

Merged
merged 5 commits into from
Jun 17, 2021

Conversation

timebertt
Copy link
Member

@timebertt timebertt commented Jun 16, 2021

How to categorize this PR?

/area open-source
/kind cleanup

What this PR does / why we need it:

Small follow-ups after #4215, namely:

  • Replace deprecated NewFakeClientWithScheme
  • vendor sigs.k8s.io/controller-tools@v0.6.0
  • improve envtest stop behavior
  • increase envtest timeouts

Which issue(s) this PR fixes:
With this, all needed steps for #4174 should be done here.
Closes #4174

Special notes for your reviewer:

/squash

Release note:


@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up merge/squash size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 16, 2021
@gardener-robot gardener-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 16, 2021
@timebertt
Copy link
Member Author

/ready
/invite @rfranzke

@gardener-robot gardener-robot marked this pull request as ready for review June 16, 2021 10:25
@gardener-robot gardener-robot requested a review from a team as a code owner June 16, 2021 10:25
- don't panic in Environment.Stop
- make sure all cleanup gets done in Stop
Increases timeouts even more to make envtests in pipelines
more stable.
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/squash

@timebertt timebertt merged commit db7118f into gardener:master Jun 17, 2021
@timebertt timebertt deleted the cleanup/c-r branch June 17, 2021 06:44
harishmanasa pushed a commit to harishmanasa/gardener that referenced this pull request Jul 9, 2021
* Replace deprecated NewFakeClientWithScheme

* go mod edit -require=sigs.k8s.io/controller-tools@v0.6.0

* [automated] make revendor

* Improve envtest stop behavior

- don't panic in Environment.Stop
- make sure all cleanup gets done in Stop

* Increase envtest timeouts

Increases timeouts even more to make envtests in pipelines
more stable.
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
* Replace deprecated NewFakeClientWithScheme

* go mod edit -require=sigs.k8s.io/controller-tools@v0.6.0

* [automated] make revendor

* Improve envtest stop behavior

- don't panic in Environment.Stop
- make sure all cleanup gets done in Stop

* Increase envtest timeouts

Increases timeouts even more to make envtests in pipelines
more stable.
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
* Replace deprecated NewFakeClientWithScheme

* go mod edit -require=sigs.k8s.io/controller-tools@v0.6.0

* [automated] make revendor

* Improve envtest stop behavior

- don't panic in Environment.Stop
- make sure all cleanup gets done in Stop

* Increase envtest timeouts

Increases timeouts even more to make envtests in pipelines
more stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade sigs.k8s.io/controller-runtime to v0.9, k8s.io/* to v0.21
7 participants