-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small follow-ups after vendoring controller-runtime #4217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
kind/cleanup
Something that is not needed anymore and can be cleaned up
merge/squash
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Jun 16, 2021
gardener-robot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Jun 16, 2021
/ready |
ialidzhikov
reviewed
Jun 16, 2021
- don't panic in Environment.Stop - make sure all cleanup gets done in Stop
Increases timeouts even more to make envtests in pipelines more stable.
rfranzke
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
ialidzhikov
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/squash
harishmanasa
pushed a commit
to harishmanasa/gardener
that referenced
this pull request
Jul 9, 2021
* Replace deprecated NewFakeClientWithScheme * go mod edit -require=sigs.k8s.io/controller-tools@v0.6.0 * [automated] make revendor * Improve envtest stop behavior - don't panic in Environment.Stop - make sure all cleanup gets done in Stop * Increase envtest timeouts Increases timeouts even more to make envtests in pipelines more stable.
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Replace deprecated NewFakeClientWithScheme * go mod edit -require=sigs.k8s.io/controller-tools@v0.6.0 * [automated] make revendor * Improve envtest stop behavior - don't panic in Environment.Stop - make sure all cleanup gets done in Stop * Increase envtest timeouts Increases timeouts even more to make envtests in pipelines more stable.
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Replace deprecated NewFakeClientWithScheme * go mod edit -require=sigs.k8s.io/controller-tools@v0.6.0 * [automated] make revendor * Improve envtest stop behavior - don't panic in Environment.Stop - make sure all cleanup gets done in Stop * Increase envtest timeouts Increases timeouts even more to make envtests in pipelines more stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
kind/cleanup
Something that is not needed anymore and can be cleaned up
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/kind cleanup
What this PR does / why we need it:
Small follow-ups after #4215, namely:
NewFakeClientWithScheme
sigs.k8s.io/controller-tools@v0.6.0
Which issue(s) this PR fixes:
With this, all needed steps for #4174 should be done here.
Closes #4174
Special notes for your reviewer:
/squash
Release note: