Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestLimitExceeded is now treated as ERR_INFRA_RATE_LIMITS_EXCEEDED #4236

Merged
merged 1 commit into from Jun 21, 2021
Merged

RequestLimitExceeded is now treated as ERR_INFRA_RATE_LIMITS_EXCEEDED #4236

merged 1 commit into from Jun 21, 2021

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area ops-productivity
/kind enhancement

What this PR does / why we need it:
RequestLimitExceeded is now treated as ERR_INFRA_RATE_LIMITS_EXCEEDED.

Release note:

Error messages containing `RequestLimitExceeded` are now treated as `ERR_INFRA_RATE_LIMITS_EXCEEDED` (instead of `ERR_INFRA_QUOTA_EXCEEDED` before).

@rfranzke rfranzke requested a review from a team as a code owner June 21, 2021 08:47
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2021
@rfranzke rfranzke requested a review from vpnachev June 21, 2021 11:18
vpnachev
vpnachev approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

timebertt
timebertt approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timebertt timebertt merged commit 64a60b4 into gardener:master Jun 21, 2021
@rfranzke rfranzke deleted the enh/err-mapp branch June 21, 2021 13:07
@vpnachev
Copy link
Member

/needs cherry-pick

This was referenced Jun 23, 2021
Merged
Merged
Merged
@vpnachev
Copy link
Member

/remove needs/cherry-pick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rfranzke @vpnachev @timebertt @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot