New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile annotations and labels of ResourceQuota #4264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/robustness
Robustness, reliability, resilience related
kind/enhancement
Enhancement, improvement, extension
needs/review
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Jun 25, 2021
cc @rfranzke |
rfranzke
previously approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@petersutter Can you please check the failing |
rfranzke
approved these changes
Jun 28, 2021
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* reconcile annotations and labels of ResourceQuota * Update controller-manager.md * appease linter
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* reconcile annotations and labels of ResourceQuota * Update controller-manager.md * appease linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/robustness
Robustness, reliability, resilience related
kind/enhancement
Enhancement, improvement, extension
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area robustness
/kind enhancement
What this PR does / why we need it:
This PR enhances the Project controller to merge
annotations
andlabels
defined on the resource quota configuration with project resource quotas.This is needed in case resource quotas need to be updated by an automation script. In this case you could update the default resource quota configuration and set a special annotation to mark it as "already updated". The automation script can then skip such resource quotas and only update those resource quotas that are not marked as "already updated".
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: