Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile annotations and labels of ResourceQuota #4264

Merged
merged 3 commits into from Jun 29, 2021
Merged

Reconcile annotations and labels of ResourceQuota #4264

merged 3 commits into from Jun 29, 2021

Conversation

petersutter
Copy link
Contributor

How to categorize this PR?
/area robustness
/kind enhancement

What this PR does / why we need it:
This PR enhances the Project controller to merge annotations and labels defined on the resource quota configuration with project resource quotas.

This is needed in case resource quotas need to be updated by an automation script. In this case you could update the default resource quota configuration and set a special annotation to mark it as "already updated". The automation script can then skip such resource quotas and only update those resource quotas that are not marked as "already updated".

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Labels and annotations on the `ResourceQuota` `config` get merged with the respective fields on existing `ResourceQuota`s

@petersutter petersutter requested a review from a team as a code owner June 25, 2021 13:03
@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2021
@petersutter
Copy link
Contributor Author

cc @rfranzke

rfranzke
rfranzke previously approved these changes Jun 25, 2021
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke
Copy link
Member

@petersutter Can you please check the failing verify step?

@rfranzke rfranzke merged commit d51c48a into gardener:master Jun 29, 2021
@petersutter petersutter deleted the enh/reconcile-quota branch June 30, 2021 06:54
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
* reconcile annotations and labels of ResourceQuota

* Update controller-manager.md

* appease linter
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
* reconcile annotations and labels of ResourceQuota

* Update controller-manager.md

* appease linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants