Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SeedSelector from GardenletConfiguration #4306

Merged
merged 6 commits into from Jul 9, 2021
Merged

Remove SeedSelector from GardenletConfiguration #4306

merged 6 commits into from Jul 9, 2021

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jul 2, 2021 •
edited by timebertt

How to categorize this PR?

/area dev-productivity
/kind technical-debt

What this PR does / why we need it:
This PR removes the SeedSelector field from the GardenletConfiguration struct.

Which issue(s) this PR fixes:
Part of #4078.

Special notes for your reviewer:

Release note:

Gardenlet does not support seedSelectors anymore; configure an explicit seedConfig in the GardenletConfiguration instead

@gardener-robot
Copy link

@xrstf Labels area/todo, kind/todo do not exist.

@gardener-robot
Copy link

@xrstf Thank you for your contribution.

@gardener-robot gardener-robot added needs/review size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 2, 2021
@timebertt timebertt self-assigned this Jul 5, 2021
@xrstf xrstf force-pushed the remove-gardenlet-seed-seector branch from 23058f0 to bd27637 Compare July 5, 2021 12:11
@xrstf xrstf marked this pull request as ready for review July 5, 2021 12:53
@xrstf xrstf requested a review from a team as a code owner July 5, 2021 12:53
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly labels Jul 5, 2021
@xrstf xrstf mentioned this pull request Jul 5, 2021
Merged
timebertt
timebertt requested changes Jul 6, 2021
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
See feedback inline for some further cleanup potential :)

charts/gardener/gardenlet/charts/runtime/templates/configmap-componentconfig.yaml Show resolved Hide resolved
cmd/gardenlet/app/gardenlet.go Outdated Show resolved Hide resolved
docs/concepts/gardenlet.md Show resolved Hide resolved
pkg/controllerutils/seedfilter.go Outdated Show resolved Hide resolved
pkg/controllerutils/seedfilter.go Outdated Show resolved Hide resolved
pkg/controllerutils/seedfilter.go Outdated Show resolved Hide resolved
pkg/gardenlet/apis/config/validation/validation.go Show resolved Hide resolved
pkg/gardenlet/bootstrap/certificate/certificate_rotation.go Outdated Show resolved Hide resolved
pkg/gardenlet/controller/seed/seed.go Outdated Show resolved Hide resolved
pkg/gardenlet/controller/seed/seed.go Outdated Show resolved Hide resolved
@xrstf xrstf requested a review from a team as a code owner July 6, 2021 19:53
timebertt
timebertt requested changes Jul 7, 2021
View reviewed changes
docs/concepts/gardenlet.md Outdated Show resolved Hide resolved
docs/concepts/gardenlet.md Show resolved Hide resolved
pkg/client/kubernetes/clientmap/internal/seed_clientmap.go Show resolved Hide resolved
pkg/controllerutils/seedfilter.go Show resolved Hide resolved
pkg/controllerutils/seedfilter.go Show resolved Hide resolved
@xrstf xrstf force-pushed the remove-gardenlet-seed-seector branch from f2db36e to be4a79d Compare July 7, 2021 12:40
timebertt
timebertt reviewed Jul 8, 2021
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment code-wise. Otherwise looks good.
Will test it tomorrow.

pkg/client/kubernetes/clientmap/internal/seed_clientmap.go Show resolved Hide resolved
@gardener-robot
Copy link

@xrstf You have pull request review with status CHANGES_REQUESTED, please check

timebertt
timebertt approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@timebertt timebertt merged commit 4db3813 into gardener:master Jul 9, 2021
@xrstf xrstf deleted the remove-gardenlet-seed-seector branch July 9, 2021 07:22
vanjiii pushed a commit to vanjiii/gardener that referenced this pull request Jul 9, 2021
@xrstf
Remove SeedSelector from GardenletConfiguration (gardener#4306)
92f5ce1
@timuthy timuthy mentioned this pull request Sep 30, 2021
Merged
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@xrstf
Remove SeedSelector from GardenletConfiguration (gardener#4306)
c9bf967
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@xrstf
Remove SeedSelector from GardenletConfiguration (gardener#4306)
2b87c0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@timebertt timebertt timebertt approved these changes

Assignees

@timebertt timebertt

Labels
area/dev-productivity Developer productivity related (how to improve development) kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@xrstf @gardener-robot @rfranzke @timebertt @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3