Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.24] Automated cherry pick of #4327: When defaulting and maintaining OS version, prefer older and supported version over newer but deprecated #4343

Merged
merged 5 commits into from Jul 13, 2021
Merged

[release-v1.24] Automated cherry pick of #4327: When defaulting and maintaining OS version, prefer older and supported version over newer but deprecated #4343

merged 5 commits into from Jul 13, 2021

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Jul 9, 2021

/area/ops-productivity
/kind/bug

Cherry pick of #4327 on release-v1.24.

#4327: When defaulting and maintaining OS version, prefer older and supported version over newer but deprecated

Release Notes:

A bug that the shoot maintenance controller was upgrading the OS version to higher but deprecated version instead of using lower and supported has been fixed.

A bug that the OS version of worker pool is defaulted to higher and deprecated version instead of lower and supported is now fixed.

@vpnachev vpnachev requested a review from a team as a code owner July 9, 2021 19:43
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) kind/bug Bug needs/review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2021
@vpnachev vpnachev added merge/squash and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 9, 2021
@timebertt
Copy link
Member

Can you check the verify failure?

@gardener-robot gardener-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 12, 2021
@vpnachev
Copy link
Member Author

Can you check the verify failure?

Fixed.
Thanks for spotting it!

ialidzhikov
ialidzhikov approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vpnachev vpnachev merged commit 4be7786 into gardener:release-v1.24 Jul 13, 2021
@vpnachev vpnachev deleted the automated-cherry-pick-of-#4327-origin-release-v1.24 branch July 13, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/bug Bug size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vpnachev @timebertt @ialidzhikov @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot