Cleanup duplicated watches in gardenlet (2) #4510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/scalability
12 tasks
Also: - refactor to reconcile.Reconciler - consistently use logger with object name field - simplify unit tests, switch to fake client
timebertt
force-pushed
the
cleanup/duplicated-watches-2
branch
from
bf816d1
to
b053657
Compare
|
/assign |
rfranzke
approved these changes
Aug 17, 2021
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Use c-r informer for Seeds in Shoot controller * Cleanup garden.ReadGardenSecrets after dropping seed lister * Eliminate informers, listers in pkg/operation * Eliminate informers, listers in shoot care controller * Eliminate informers, lister in seed registration controller Also: - refactor to reconcile.Reconciler - consistently use logger with object name field - simplify unit tests, switch to fake client * Cleanup some more logging stuff in shoot care controller * Use c-r informer for Shoots in Shoot controller * Completely eliminate generated informers, listers in gardenlet
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Use c-r informer for Seeds in Shoot controller * Cleanup garden.ReadGardenSecrets after dropping seed lister * Eliminate informers, listers in pkg/operation * Eliminate informers, listers in shoot care controller * Eliminate informers, lister in seed registration controller Also: - refactor to reconcile.Reconciler - consistently use logger with object name field - simplify unit tests, switch to fake client * Cleanup some more logging stuff in shoot care controller * Use c-r informer for Shoots in Shoot controller * Completely eliminate generated informers, listers in gardenlet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area scalability
/kind cleanup
What this PR does / why we need it:
This PR cleans up usages of the generated informers (client-go style) in gardenlet's Shoot controller.
It replaces them with informers from the controller-runtime cache to prevent duplicated watches if the
CachedRuntimeClientsfeature gate is enabled.To ease the transition, the PR also refactors the seed registration controller to the
reconcile.Reconcilerinterface.Now, the use of generated informers and listers is completely eliminated in gardenlet.
Hence, it should now be safer to turn on the
CachedRuntimeClientsfeature gate again.(similar to #4503, #3658 ff., #3746 ff.)
Which issue(s) this PR fixes:
Part of #2822, #4251
Special notes for your reviewer:
Performed some additional cleanups like in #4503 along the way (mainly related to logging and fake clients in unit tests).
/squash
Release note: