Drop unused generated clients #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The funcs add all versioned API types (i.e., all but internal types). They can be used as an replacement for the AddToScheme funcs generated by client-gen.
gardener-robot
added
area/dev-productivity
rfranzke
reviewed
Sep 1, 2021
timebertt
force-pushed
the
cleanup/drop-generated-clients
branch
from
d307c39
to
d172215
Compare
That won't be possible so easily, as they are used in admission plugins. However, what is possible and planned is to remove usages of |
16 tasks
|
/squash |
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Add AddToScheme to all install packages
The funcs add all versioned API types (i.e., all but internal types).
They can be used as an replacement for the AddToScheme funcs generated
by client-gen.
* Replace usages of generated schemes
* Drop generated extensions client
* Remove usages of generated operations client
* Drop generated operations client
* Drop unused API{Registration,Extension} from kubernetes.Interface
* [generated] make revendor
* Replace usages of kubernetes.Interface.GardenSeedManagement()
* Drop unused Garden{Core,SeedManagement} from kubernetes.Interface
* Drop unused ForwardPodPort from kubernetes.Interface
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Add AddToScheme to all install packages
The funcs add all versioned API types (i.e., all but internal types).
They can be used as an replacement for the AddToScheme funcs generated
by client-gen.
* Replace usages of generated schemes
* Drop generated extensions client
* Remove usages of generated operations client
* Drop generated operations client
* Drop unused API{Registration,Extension} from kubernetes.Interface
* [generated] make revendor
* Replace usages of kubernetes.Interface.GardenSeedManagement()
* Drop unused Garden{Core,SeedManagement} from kubernetes.Interface
* Drop unused ForwardPodPort from kubernetes.Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area scalability dev-productivity
/kind cleanup
What this PR does / why we need it:
This PR drops some unused generated client code (extensions and operations group).
It also drops some unused clients (
Garden{Core,SeedManagement,Operations}andAPI{Registration,Extension}) fromkubernetes.Interface.All of this is dropped in favor of (cached) controller-runtime clients to simplify/unify our code and leverage the clients' caches wherever possible.
Which issue(s) this PR fixes:
Part of #2414
Special notes for your reviewer:
kubernetes.Interface.Kubernetes()is not dropped in this PR, as there are still a lot of usages.This can be tackled in a future PR.
The generated operations clients might be needed in the future, when we add some checks in admission plugins (e.g. for
Bastions). I decided to drop them nevertheless for the sake of simplification. We can still add them back with a few lines later on if needed.Release note: