-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v1.31] Automated cherry pick of #4629: Fix format data device #4634
[release-v1.31] Automated cherry pick of #4629: Fix format data device #4634
Conversation
Pick only a non mounted device when finding the right device to be formatted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this is a cherry-pick PR, but probably makes sense the same to be fixed in the other branches, or at least in the master.
done <<< "$DISK_DEVICES" | ||
|
||
if [ -z "$TARGET_DEVICE_NAME" ]; then | ||
echo "No kubelet data device not found" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "No kubelet data device not found" | |
echo "No kubelet data device found" |
done <<< "$DISK_DEVICES" | ||
|
||
if [ -z "$TARGET_DEVICE_NAME" ]; then | ||
echo "No kubelet data device not found" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "No kubelet data device not found" | |
echo "No kubelet data device found" |
Let's merge this as is for now and fix it in master only. |
/kind/bug
/area/os
Cherry pick of #4629 on release-v1.31.
#4629: Fix format data device
Release Notes: