Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.31] Automated cherry pick of #4629: Fix format data device #4634

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Sep 9, 2021

/kind/bug
/area/os

Cherry pick of #4629 on release-v1.31.

#4629: Fix format data device

Release Notes:

An issue has been fixed which caused a worker node with a configured data disk not to get ready. This issue only happened if the data disk was of the same size as the boot disk.

Pick only a non mounted device when finding the right device to be formatted.
@timuthy timuthy requested a review from a team as a code owner September 9, 2021 13:05
@gardener-robot gardener-robot added area/os Operator system related kind/bug Bug needs/review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2021
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is a cherry-pick PR, but probably makes sense the same to be fixed in the other branches, or at least in the master.

done <<< "$DISK_DEVICES"

if [ -z "$TARGET_DEVICE_NAME" ]; then
echo "No kubelet data device not found"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "No kubelet data device not found"
echo "No kubelet data device found"

done <<< "$DISK_DEVICES"

if [ -z "$TARGET_DEVICE_NAME" ]; then
echo "No kubelet data device not found"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "No kubelet data device not found"
echo "No kubelet data device found"

@rfranzke
Copy link
Member

rfranzke commented Sep 9, 2021

Let's merge this as is for now and fix it in master only.

@rfranzke rfranzke merged commit b69801f into gardener:release-v1.31 Sep 9, 2021
@timuthy timuthy deleted the automated-cherry-pick-of-#4629-origin-release-v1.31 branch September 9, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/os Operator system related kind/bug Bug size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants