Only patch shoot status label if necessary #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/cost
16 tasks
|
Would be nice to have this in v1.34.0 to see the effect in larger gardener landscapes soon. cc @plkokanov |
|
/milestone v1.34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area scalability cost
/kind enhancement
What this PR does / why we need it:
Only patch shoot status label if necessary (if it actually changed) in order to save network traffic.
Which issue(s) this PR fixes:
Part of #2414
Special notes for your reviewer:
We probably want to move the status label handling to gcm (see #4286 (comment)).
For now, this is not changed and the optimization is simply applied to the current mechanism in gardenlet.
Release note: