Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare switch to logr #4925

Merged
merged 4 commits into from
Oct 29, 2021
Merged

Conversation

timebertt
Copy link
Member

@timebertt timebertt commented Oct 27, 2021

How to categorize this PR?

/area dev-productivity
/kind cleanup

What this PR does / why we need it:

Cleans up some logging helpers and stuff to prepare the switch from logrus to logr.
Now, we reuse the helpers from c-r to their full potential and drop custom coding that does the same.

Which issue(s) this PR fixes:
Part of #4251

Special notes for your reviewer:

Release note:

None

Make use of the simplified helpers in the components as well, that
use statically configured loggers.
(only a bit, this should be further harmonized)
@timebertt timebertt requested a review from a team as a code owner October 27, 2021 15:42
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up needs/review labels Oct 27, 2021
@gardener-robot gardener-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs/review labels Oct 27, 2021
@rfranzke
Copy link
Member

Can you run make revendor?

@rfranzke
Copy link
Member

@timebertt There is still something wrong in the verify step 👀

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from the failing verify step

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timebertt timebertt merged commit d078fc8 into gardener:master Oct 29, 2021
@timebertt timebertt deleted the refactor/prepare-logr branch October 29, 2021 07:17
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
* Simplify logging helpers

* Use simplified helpers

Make use of the simplified helpers in the components as well, that
use statically configured loggers.

* Harmonize startup logs

(only a bit, this should be further harmonized)

* make revendor
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
* Simplify logging helpers

* Use simplified helpers

Make use of the simplified helpers in the components as well, that
use statically configured loggers.

* Harmonize startup logs

(only a bit, this should be further harmonized)

* make revendor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants