-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare switch to logr #4925
Merged
Merged
Prepare switch to logr #4925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of the simplified helpers in the components as well, that use statically configured loggers.
(only a bit, this should be further harmonized)
76 tasks
Can you run |
@timebertt There is still something wrong in the |
rfranzke
reviewed
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm apart from the failing verify
step
67814fd
to
0658d57
Compare
rfranzke
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Simplify logging helpers * Use simplified helpers Make use of the simplified helpers in the components as well, that use statically configured loggers. * Harmonize startup logs (only a bit, this should be further harmonized) * make revendor
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Simplify logging helpers * Use simplified helpers Make use of the simplified helpers in the components as well, that use statically configured loggers. * Harmonize startup logs (only a bit, this should be further harmonized) * make revendor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/dev-productivity
Developer productivity related (how to improve development)
kind/cleanup
Something that is not needed anymore and can be cleaned up
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind cleanup
What this PR does / why we need it:
Cleans up some logging helpers and stuff to prepare the switch from
logrus
tologr
.Now, we reuse the helpers from c-r to their full potential and drop custom coding that does the same.
Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer:
Release note: