Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update istio to version 1.12.0 #5080

Merged
merged 1 commit into from
Dec 9, 2021
Merged

update istio to version 1.12.0 #5080

merged 1 commit into from
Dec 9, 2021

Conversation

DockToFuture
Copy link
Member

@DockToFuture DockToFuture commented Nov 26, 2021 •
edited

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
Update istio to version 1.12.0 since support for istio version 1.10.x is dropped by the end of year. See: https://istio.io/latest/docs/releases/supported-releases/.
Additionally clean up old envoyfilter which are no longer required.

Special notes for your reviewer:

The metadata exchange server are no longer required in istio 1.12.0

Release note:

Update istio to version `1.12.0`.

@DockToFuture DockToFuture requested a review from a team as a code owner November 26, 2021 15:44
@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2021
@DockToFuture DockToFuture mentioned this pull request Nov 26, 2021
Closed
ScheererJ
ScheererJ approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot
Copy link

@ScheererJ Command /lgtm is not available to you but only to a Maintainer, Member.

ScheererJ
ScheererJ requested changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the envoy filters as well.

@DockToFuture DockToFuture marked this pull request as draft November 29, 2021 15:07
@gardener-robot gardener-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2021
@DockToFuture DockToFuture marked this pull request as ready for review November 30, 2021 10:50
ScheererJ
ScheererJ requested changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the metadata envoy filter as discussed as they are natively implemented in istio 1.12.

@gardener-robot gardener-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 1, 2021
@gardener-robot gardener-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 1, 2021
ScheererJ
ScheererJ previously approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@DockToFuture DockToFuture dismissed stale reviews from rfranzke and ScheererJ via a216753 December 6, 2021 13:31
@gardener-robot gardener-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2021
@DockToFuture DockToFuture marked this pull request as draft December 6, 2021 16:05
@DockToFuture DockToFuture marked this pull request as ready for review December 7, 2021 09:10
ScheererJ
ScheererJ approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot
Copy link

@ScheererJ Command /lgtm is not available to you but only to a Maintainer, Member.

@rfranzke
Copy link
Member

rfranzke commented Dec 9, 2021

@ialidzhikov Do you have further comments?

@ialidzhikov
Copy link
Member

@ialidzhikov Do you have further comments?

Let me check again

ialidzhikov
ialidzhikov approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/needs second-opinion

rfranzke
rfranzke approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@rfranzke rfranzke merged commit c512859 into gardener:master Dec 9, 2021
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@DockToFuture
update istio to version 1.12.0 (gardener#5080)
193e2be
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@DockToFuture
update istio to version 1.12.0 (gardener#5080)
4968576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@rfranzke rfranzke rfranzke approved these changes

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees

@DockToFuture DockToFuture

Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@DockToFuture @gardener-robot @rfranzke @ialidzhikov @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3