Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract and collect error codes from ManagedResources #5111

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Extract and collect error codes from ManagedResources #5111

merged 2 commits into from
Dec 9, 2021

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Dec 2, 2021

How to categorize this PR?

/area ops-productivity
/kind enhancement

What this PR does / why we need it:
This PR makes the WaitUntilManagedResourcesDeleted to detect and extract error codes from the ManagedResources that is stuck in deletion.

Release note:

The error code detection has been enhanced for `ManagedResource` objects that are stuck when a shoot is deleted. This enables Gardener to assign the corresponding error code(s) to the shoot object.

@timuthy timuthy requested a review from a team as a code owner December 2, 2021 21:10
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension needs/review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2021
rfranzke
rfranzke requested changes Dec 6, 2021
View reviewed changes
pkg/apis/core/v1beta1/helper/errors.go Outdated Show resolved Hide resolved
pkg/gardenlet/controller/shoot/shoot_control_delete.go Outdated Show resolved Hide resolved
@timuthy
Copy link
Contributor Author

timuthy commented Dec 7, 2021

Thanks for your review @rfranzke. PTAL.

rfranzke
rfranzke approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit d0d451b into gardener:master Dec 9, 2021
@timuthy timuthy deleted the feature.propagate-mr-errors branch December 9, 2021 09:11
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@timuthy
Extract and collect error codes from ManagedResources (gardener#5111)
f376f2c 
* Extract and collect error codes from ManagedResources

* Address review comments
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@timuthy
Extract and collect error codes from ManagedResources (gardener#5111)
dda4008 
* Extract and collect error codes from ManagedResources

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@timuthy @rfranzke @danielfoehrKn @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot