Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify minAllowed for the gardener-resource-manager VPA #5116

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Specify minAllowed for the gardener-resource-manager VPA #5116

merged 1 commit into from
Dec 7, 2021

Conversation

ialidzhikov
Copy link
Member

/area control-plane
/area auto-scaling
/kind enhancement

Release note:

The gardener-resource-manager VPA does now specify minAllowed values to prevent too low resource recommendations from VPA that lead to OOM.

@ialidzhikov ialidzhikov requested a review from a team as a code owner December 6, 2021 08:54
@gardener-robot gardener-robot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2021
rfranzke
rfranzke previously approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke
Copy link
Member

rfranzke commented Dec 6, 2021 •
edited

The failing test is unrelated to the PR and gets fixed with #5117

@gardener-robot gardener-robot added needs/review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs/review labels Dec 6, 2021
@gardener-robot gardener-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2021
@ialidzhikov
Specify minAllowed for the gardener-resource-manager VPA
9476033 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov
Copy link
Member Author

From my observations:

  • GRM in Shoot controlplane
    • on avg. the leading replica is consuming 70Mi-150Mi
    • the idling ones - 15Mi-40Mi
  • GRM in the garden ns of the Seed
    • the memory usage of the leading replicas rely varies on the Seed usage
      • for a Seed with a single Shoot - 70Mi
      • for a Seed with ~10 Shoots - 380Mi
      • for a Seed with 165 Shoots - up to 2Gi
    • the idling ones are again consuming 15Mi-40Mi

Hence, for the GRM in the Shoot controlplane I set:

      minAllowed:
        cpu: 20m
        memory: 30Mi

For the one in the garden ns in the Seed:

      minAllowed:
        cpu: 20m
        memory: 64Mi

/cc @voelzmo @shreyas-s-rao

voelzmo
voelzmo approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@voelzmo voelzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for making the extra effort of checking the current usages!

@rfranzke rfranzke merged commit b2ab3a3 into gardener:master Dec 7, 2021
@ialidzhikov ialidzhikov deleted the enh/grm-min-allowed branch December 8, 2021 10:25
@timebertt timebertt mentioned this pull request Dec 9, 2021
Merged
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@ialidzhikov
Specify minAllowed for the gardener-resource-manager VPA (gardener#5116)
00cd271 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@ialidzhikov
Specify minAllowed for the gardener-resource-manager VPA (gardener#5116)
e3c5d15 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voelzmo voelzmo voelzmo approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ialidzhikov @rfranzke @voelzmo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot