[GEP-17] Add force restoring of shoots and backup entries #5123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
|
/cc @plkokanov @timebertt |
stoyanr
force-pushed
the
enh/add-shoot-migration-fallback
branch
from
981026f
to
60dcc03
Compare
46 tasks
stoyanr
force-pushed
the
enh/add-shoot-migration-fallback
branch
from
60dcc03
to
98f397c
Compare
|
Rebased on latest |
|
/assign |
stoyanr
force-pushed
the
enh/add-shoot-migration-fallback
branch
from
98f397c
to
8159b92
Compare
|
/squash |
stoyanr
force-pushed
the
enh/add-shoot-migration-fallback
branch
from
daf85e4
to
cfb7bd9
Compare
|
@timebertt Thanks for your review, I answered / addressed your comments in a new commit. The one open point remaining is whether the controllers should be moved to GCM or not, let's clarify this and I will further adapt the PR if needed. |
stoyanr
force-pushed
the
enh/add-shoot-migration-fallback
branch
from
cfb7bd9
to
0306056
Compare
stoyanr
force-pushed
the
enh/add-shoot-migration-fallback
branch
from
0306056
to
0785394
Compare
stoyanr
force-pushed
the
enh/add-shoot-migration-fallback
branch
from
0785394
to
8c5bccf
Compare
timebertt
approved these changes
Dec 20, 2021
ialidzhikov
reviewed
Dec 20, 2021
| @@ -39,6 +39,7 @@ The following tables are a summary of the feature gates that you can set on diff | |||
| | WorkerPoolKubernetesVersion | `false` | `Alpha` | `1.35` | | | |||
| | CopyEtcdBackupsDuringControlPlaneMigration | `false` | `Alpha` | `1.37` | | | |||
| | SecretBindingProviderValidation | `false` | `Alpha` | `1.38` | | | |||
| | ForceRestore | `false` | `Alpha` | `1.38` | | | |||
There was a problem hiding this comment.
This has to be 1.39, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane-migration
/kind enhancement
What this PR does / why we need it:
gardenletto enable the forceful restoration of shoots and backup entries to the destination seed during control plane migration if the preparation for migration in the source seed is not finished after a certain grace period and is considered unlikely to succeed ("bad case" scenario).MigrationStartTimetoShootandBackupEntryto be able to track how much time has elapsed since the migration of the shoot / backup entries to this seed started.ForceRestoreto be able to enable / disable this forceful restoration. It depends on the feature gatesUseDNSRecordsandCopyEtcdBackupsDuringControlPlaneMigrationbeing enabled.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
spec.setttings.ownerChecks.enabled=false). Owner checks are needed in the source, because otherwise the ownership change will not be detected, and in the destination, because otherwise the owner DNS record will not be created and the destination will not overtake the source as the owner.gardenlet, even though there are no strong reasons to prefergardenletover GCM. There are a few "weak" reasons:gardenletin such a seed would most likely also not be able to force the restoration (which is from my perspective better).Release note:
If the `ForceRestore` feature gate is enabled, the shoot's restoration to the destination seed during control plane migration will be forced if the preparation for migration in the source seed is not finished after a certain grace period and is considered unlikely to succeed ("bad case" scenario).