Several improvements for the resources.gardener.cloud/preserve-{replicas,resources} option for managed resources
#5131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
acumino
reviewed
Dec 7, 2021
|
@ScheererJ Command |
acumino
previously approved these changes
Dec 8, 2021
|
@ScheererJ Command |
rfranzke
force-pushed
the
enh/grm-preserve-resources
branch
from
ce8bede
to
9c5b444
Compare
gardener-robot
added
the
size/M
gardener-robot
removed
the
size/L
|
@rfranzke feel free to merge since you are the release responsible but a milestone has not been created yet (just to be sure). |
rfranzke
added a commit
that referenced
this pull request
Jan 13, 2022
…for the `resources.gardener.cloud/preserve-{replicas,resources}` option for managed resources (#5264)
* Add missing documentation for `preserve-{resources,replicas}` options
* Fix `mergeStatefulSet`, add unit tests for `preserveResources` option
* Implement `preserve-{replicas,resources}` for missing workload APIs
* Address PR review feedback
* Address PR review feedback
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
…icas,resources}` option for managed resources (gardener#5131) * Add missing documentation for `preserve-{resources,replicas}` options * Fix `mergeStatefulSet`, add unit tests for `preserveResources` option * Implement `preserve-{replicas,resources}` for missing workload APIs * Address PR review feedback * Address PR review feedback
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
…icas,resources}` option for managed resources (gardener#5131) * Add missing documentation for `preserve-{resources,replicas}` options * Fix `mergeStatefulSet`, add unit tests for `preserveResources` option * Implement `preserve-{replicas,resources}` for missing workload APIs * Address PR review feedback * Address PR review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area scalability
/kind enhancement bug
/merge squash
What this PR does / why we need it:
This PR
resources.gardener.cloud/preserve-{replicas,resources}options for managed resources.resources.gardener.cloud/preserve-resourcesoption from working properly forStatefulSets.resources.gardener.cloud/preserve-resourcesoption forJobs,CronJobs, andDaemonSets.Special notes for your reviewer:
/cc @ScheererJ @DockToFuture
Release note: