Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create owner DNSRecord during shoot deletion #5135

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Create owner DNSRecord during shoot deletion #5135

merged 1 commit into from
Dec 9, 2021

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented Dec 8, 2021 •
edited by rfranzke

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:
Adds a new step deployOwnerDomainDNSRecord to the shoot deletion flow that is exactly the same as the step in the shoot reconciliation flow in order to fix the issue described in #5132.

  • If the owner DNSRecord already exists, it will not be reconciled (since this resource is "special" and only reconciled upon creation or spec change).
  • If the owner DNSRecord doesn't exist however (e.g. the shoot was never reconciled with UseDNSRecords enabled), it will be created and the subsequent failures described in the above issue will be avoided.

Which issue(s) this PR fixes:
Fixes #5132

Special notes for your reviewer:

Release note:

Fixed a bug that prevented shoot deletion with `UseDNSRecords` enabled if it was never previously reconciled with this feature gate enabled.

@stoyanr stoyanr requested a review from a team as a code owner December 8, 2021 14:37
@gardener-robot gardener-robot added needs/review area/control-plane Control plane related kind/bug Bug size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2021
@stoyanr
Copy link
Contributor Author

stoyanr commented Dec 8, 2021

/invite @timebertt

rfranzke
rfranzke approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

timebertt
timebertt approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
/lgtm
/needs cherry-pick

@timebertt timebertt merged commit b061de7 into gardener:master Dec 9, 2021
@stoyanr stoyanr deleted the fix/create-owner-dns-record-during-deletion branch December 9, 2021 07:29
@timebertt timebertt mentioned this pull request Dec 9, 2021
Merged
@stoyanr stoyanr mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shoot can't be deleted with UseDNSRecords=true if it was never reconciled with UseDNSRecords=false
6 participants
@stoyanr @rfranzke @timebertt @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot