Disable etcd backup compaction by default #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/control-plane
rfranzke
previously approved these changes
Dec 9, 2021
|
@timuthy Can you please fix the failing tests? |
|
@dguendisch, @mvladev, @ialidzhikov, @plkokanov, @timuthy, @vpnachev, @schrodit, @danielfoehrKn, @BeckerMax, @timebertt, @hendrikKahl, @kris94, @voelzmo, @stoyanr This pullrequest was referenced by @rfranzke in duplicate pullrequest #5147. |
timuthy
force-pushed
the
enhancement.etcd-compaction
branch
from
4e8467c
to
eb6ab38
Compare
Earlier, paramters in `etcdConfig` were hard coded and now the very same values became the default. However, these defaults are only active if we don't overwrite them via the values in the Helm chart.
gardener-robot
added
needs/review
size/S
|
Through #5147 another problem has drawn my attention: We set very low worker values in the Helm chart which become the "new" default when applying Gardenlet via this chart. For instance, if an operator applied Gardenlet earlier, the |
shreyas-s-rao
approved these changes
Dec 10, 2021
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Disable etcd backup compaction by default * Disable etcdConfig in Gardenlet chart Earlier, paramters in `etcdConfig` were hard coded and now the very same values became the default. However, these defaults are only active if we don't overwrite them via the values in the Helm chart.
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Disable etcd backup compaction by default * Disable etcdConfig in Gardenlet chart Earlier, paramters in `etcdConfig` were hard coded and now the very same values became the default. However, these defaults are only active if we don't overwrite them via the values in the Helm chart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
What this PR does / why we need it:
This PR disables the etcd backup compaction feature by default. It should consciously be enabled by operators because the feature comes with certain cost implications (e.g. network traffic) and requires machines with a rather large root disk.
Release note: