Add rateLimit fields to DNSProvider CRD #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
kind/enhancement
|
@MartinWeindel Label area/controlplane does not exist. |
gardener-robot
added
the
size/XS
rfranzke
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
/lgtm
Btw, @MartinWeindel @stoyanr, this reminds me that we should get rid of this dns.gardener.cloud handling in g/g and move it to the DNS extension.
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
What this PR does / why we need it:
With PR gardener/external-dns-management#229 optional fields have been added to the
DNSProviderto specify client-side rate limits.The custom resource definition is updated to reflect this change.
Additionally the
DNSOwnerCRD has been updated. The JSON path for the printer columnACTIVEhas been changed to.status.activeas it is already defined in theexternal-dns-managementproject.It was not possible to include this change in the original PR #4960 because of backwards compatibility. The
.status.activefield was not set in older version of the dns-controller-manager.Release note: