Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not overwrite spec.selector for Jobs #5167

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Do not overwrite spec.selector for Jobs #5167

merged 1 commit into from
Dec 15, 2021

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Dec 15, 2021 •
edited by rfranzke

How to categorize this PR?

/area quality
/kind bug

What this PR does / why we need it:
spec.selector is immutable for Job objects.

See https://github.com/kubernetes/kubernetes/blob/c16b2afc1d3c32462f068ea08cdc4791bd97b947/pkg/apis/batch/validation/validation.go#L238.

Release note:

Gardener-Resource-Manager does not try overwrite the immutable field `.spec.selector` of `Job` objects anymore.

@timuthy timuthy requested a review from a team as a code owner December 15, 2021 11:10
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 15, 2021
rfranzke
rfranzke approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit e14c573 into gardener:master Dec 15, 2021
@timuthy timuthy deleted the fix.grm-job-merge branch December 15, 2021 12:34
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@timuthy
Do not overwrite spec.selector for Jobs (gardener#5167)
2057329
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@timuthy
Do not overwrite spec.selector for Jobs (gardener#5167)
cc33857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timuthy @rfranzke @gardener-robot-ci-3 @gardener-robot