Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use systemd as cgroup driver for shoots >= 1.23" #5324

Merged
merged 1 commit into from Jan 27, 2022
Merged

Revert "Use systemd as cgroup driver for shoots >= 1.23" #5324

merged 1 commit into from Jan 27, 2022

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Jan 26, 2022 •
edited

How to categorize this PR?

/area open-source
/kind enhancement

What this PR does / why we need it:
This reverts commit b16cc48 introduced as part #5255.
It seems that there is more to switching the cgroup driver as outlined in https://kubernetes.io/docs/setup/production-environment/container-runtimes/#containerd-systemd. Given that it's not year clear what the consequences of these changes are, let's revert them for now and rather work on them dedicatedly (I'll open an issue for following up).

Which issue(s) this PR fixes:
Part of #5102

Release note:

Shoot clusters using Kubernetes 1.23 or above will continue to use the `cgroupfs` cgroup driver (the change to use `systemd` was reverted).

@rfranzke rfranzke requested a review from a team as a code owner January 26, 2022 13:43
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 26, 2022
@rfranzke rfranzke mentioned this pull request Jan 26, 2022
Closed
20 tasks
@rfranzke rfranzke mentioned this pull request Jan 26, 2022
Open
7 tasks
vpnachev
vpnachev approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke
Copy link
Member Author

/invite @ialidzhikov @voelzmo

timuthy
timuthy approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit f60def6 into gardener:master Jan 27, 2022
@rfranzke rfranzke deleted the enh/cgroup branch January 27, 2022 09:25
@rfranzke
Copy link
Member Author

rfranzke commented Jan 27, 2022 •
edited

I will open a cherry-pick PR for this one

@timuthy timuthy mentioned this pull request Jan 27, 2022
Merged
timuthy added a commit that referenced this pull request Jan 27, 2022
@timuthy
Merge pull request #5334 from timuthy/automated-cherry-pick-of-#5324-…
1daf6ae 
…origin-release-v1.39

[release-v1.39] Automated cherry pick of #5324: Revert "Use `systemd` as cgroup driver for shoots >= 1.23"
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@rfranzke
Revert "Use systemd as cgroup driver for shoots >= 1.23" (gardener#…
8b9aed7 
…5324)

This reverts commit b16cc48.
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@rfranzke
Revert "Use systemd as cgroup driver for shoots >= 1.23" (gardener#…
42350b0 
…5324)

This reverts commit b16cc48.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@timuthy timuthy timuthy approved these changes

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

@voelzmo voelzmo Awaiting requested review from voelzmo

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rfranzke @vpnachev @timuthy @gardener-robot-ci-1 @gardener-robot