-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set RecoverPanic
to true for controller reconcile
#5383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
kind/enhancement
Enhancement, improvement, extension
labels
Feb 2, 2022
@acumino Thank you for your contribution. |
gardener-robot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Feb 2, 2022
@rfranzke, @danielfoehrKn You have pull request review open invite, please check |
rfranzke
reviewed
Feb 7, 2022
6 tasks
/author-action |
@acumino The pull request was assigned to you under |
/unassign |
rfranzke
reviewed
Feb 14, 2022
gardener-robot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Feb 14, 2022
rfranzke
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Set Recover panic true for Controllers * Minor Edit * Address PR reviews * Set Recover panic true for extensions Controllers * Address PR Review
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Set Recover panic true for Controllers * Minor Edit * Address PR reviews * Set Recover panic true for extensions Controllers * Address PR Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
kind/enhancement
Enhancement, improvement, extension
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/kind enhancement
What this PR does / why we need it:
This PR sets the
RecoverPanic
to true for the controller reconcile. Now any panics raised by the reconciler are converted to normal errors.Which issue(s) this PR fixes:
Part of #4772
Release note: