Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy gardener-resource-manager early in the shoot deletion flow #5466

Merged
merged 1 commit into from Feb 25, 2022
Merged

Destroy gardener-resource-manager early in the shoot deletion flow #5466

merged 1 commit into from Feb 25, 2022

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Feb 18, 2022 •
edited by ialidzhikov

How to categorize this PR?

/area ops-productivity
/kind enhancement

What this PR does / why we need it:
Destroy gardener-resource-manager early in the shoot deletion flow.
In the hibernation flow the GRM is already scaled down to 0 replicas, so no changes needed there.

Which issue(s) this PR fixes:
Fixes #5464

Special notes for your reviewer:
@plkokanov I will be grateful if you include this in the v1.41 milestone.

Release note:

The `gardener-resource-manager` is now destroyed early in the deletion flow. In this way there will not be a failing deployment with PDB that prevents graceful termination of seed nodes.

@vpnachev vpnachev requested a review from a team as a code owner February 18, 2022 14:48
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2022
rfranzke
rfranzke previously approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vpnachev vpnachev force-pushed the enh/destroy-resource-manager-earlier-during-deletion branch from 0654af9 to 163b931 Compare February 21, 2022 17:21
ialidzhikov
ialidzhikov approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@vpnachev
Copy link
Member Author

Friendly ping to @plkokanov to take a look and check if this can be included in the v1.41 milestone.

@rfranzke rfranzke merged commit 19f0d8d into gardener:master Feb 25, 2022
@vpnachev vpnachev deleted the enh/destroy-resource-manager-earlier-during-deletion branch February 25, 2022 14:02
@ialidzhikov ialidzhikov mentioned this pull request Mar 4, 2022
Merged
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@vpnachev
Destroy gardener-resource-manager early in the shoot deletion flow (g…
34132af 
…ardener#5466)
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@vpnachev
Destroy gardener-resource-manager early in the shoot deletion flow (g…
1980ee8 
…ardener#5466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
6 participants
@vpnachev @ialidzhikov @rfranzke @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot