Improve Grafana panels regarding Request latency #5477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subresources like log, portforward and exec might have a longer request duration by design and that does not indicate an issue in the api server. These subresources are filtered out from this graph. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>
The panel used an incorrect query before: it applied the rate function to the apiserver_latency_seconds:quantile metric. The apiserver_latency_seconds:quantile is the average latency of the requests, in seconds - the rate function is not meaningful in that case. The latency values can not be summed up in a meaningful way, but we can pick the maximum value for plotting on the panel. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>
wyb1
previously approved these changes
Feb 22, 2022
gardener-robot
added
area/monitoring
ialidzhikov
reviewed
Feb 22, 2022
...d-monitoring/charts/grafana/dashboards/owners/kubernetes-control-plane-status-dashboard.json
Outdated
Show resolved
Hide resolved
…etes-control-plane-status-dashboard.json Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
wyb1
approved these changes
Feb 23, 2022
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Exclude some subresources from the Request latency panel The subresources like log, portforward and exec might have a longer request duration by design and that does not indicate an issue in the api server. These subresources are filtered out from this graph. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com> * Fix the request latency panel The panel used an incorrect query before: it applied the rate function to the apiserver_latency_seconds:quantile metric. The apiserver_latency_seconds:quantile is the average latency of the requests, in seconds - the rate function is not meaningful in that case. The latency values can not be summed up in a meaningful way, but we can pick the maximum value for plotting on the panel. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com> * Update charts/seed-monitoring/charts/grafana/dashboards/owners/kubernetes-control-plane-status-dashboard.json Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com> Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Exclude some subresources from the Request latency panel The subresources like log, portforward and exec might have a longer request duration by design and that does not indicate an issue in the api server. These subresources are filtered out from this graph. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com> * Fix the request latency panel The panel used an incorrect query before: it applied the rate function to the apiserver_latency_seconds:quantile metric. The apiserver_latency_seconds:quantile is the average latency of the requests, in seconds - the rate function is not meaningful in that case. The latency values can not be summed up in a meaningful way, but we can pick the maximum value for plotting on the panel. Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com> * Update charts/seed-monitoring/charts/grafana/dashboards/owners/kubernetes-control-plane-status-dashboard.json Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com> Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com> Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area monitoring
/kind enhancement
What this PR does / why we need it:
Improve Grafana panels regarding Request latency
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: