Set ingress DNSRecord component values even if the addon is disabled #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
gardener-robot
added
area/quality
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
…ardener#5482) Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
…ardener#5482) Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/area quality
/kind bug
With this PR we set the DNSRecord component values (incl. the SecretData that is needed for Destroy) even if the addon is disabled. Currently when the addon gets disabled, the SecretData is not passed as value and on ingress DNSRecord Destroy, the Destroy func sets external Secret
.datato nil -> ingress DNSRecord deletion fails.Fixes #5480
Release note: