Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleaning K8s resources #5484

Merged
merged 1 commit into from Feb 25, 2022

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Feb 24, 2022

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:
This PR fixes an error that sporadically occurs during cluster deletion:

2 errors occurred:\n\t* the server could not find the requested resource (get volumesnapshots.snapshot.storage.k8s.io)\n\t* the server could not find the requested resource (get volumesnapshotcontents.snapshot.storage.k8s.io)\n\n"

It basically happened when the shoot deletion flow re-ran after the volumesnapshots, volumesnapshotcontents CRDs had already been deleted.

Special notes for your reviewer:
/cc @rfranzke @timebertt

Release note:

An error has been fixed that sporadically occurred during shoot deletion and was related to `volumesnapshots`, `volumesnapshotcontents` not being found.

@timuthy timuthy requested a review from a team as a code owner February 24, 2022 13:27
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug needs/review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2022
@timuthy
Copy link
Contributor Author

timuthy commented Feb 24, 2022

/needs cherry-pick

Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@timebertt
Copy link
Member

/assign @plkokanov for the release milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related kind/bug Bug size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants