adapt esreporter to ginkgo v2 report type

[hendrikKahl]

How to categorize this PR?

/area testing
/kind cleanup

What this PR does / why we need it:
Following the switch to ginkgo v2, the custom reporter still implemented DeprecatedReporter and was invoked via ReportViaDeprecatedReporter . The PR drops the usage of deprecated structures and interfaces and implements a custom reporting using the new Report type only.

Which issue(s) this PR fixes:
Fixes #5321

Special notes for your reviewer:
/invite @dguendisch @timebertt @rfranzke

I'm not entirely sure regarding the categorization of the release note. @timebertt would be great, if you could double-check. Thanks!

Release note:

Use ginkgo v2 `Report` structures and drop usage of deprecated custom reporter. To adapt, replace the call of `reporters.ReportViaDeprecatedReporter` within any `ReportAfterSuite` node with `reporter.ReportResults(*reportFilePath, *esIndex, report)`

Testing
Since there are no unit/integration tests and the expected output structure contains timestamps / durations, I did a smal manual testing to qualify things.

Reports generated by testruns are attached to this PR, but here are also snippets to compare the relevant structure.

using the new reporter - succeeded step

{ "index": { "_index": "gardener-testsuite", "_type": "_doc" } }
{"suite":{"name":"Shoot Test Suite","phase":"Failed","tests":9,"failures":8,"errors":0,"duration":367.428},"name":"[DEFAULT] [RELEASE] [SHOOT] should download shoot kubeconfig successfully","shortName":"[DEFAULT] [RELEASE] [SHOOT] should download shoot kubeconfig successfully","phase":"Succeeded","duration":0.080158809}

using the deprecated reporter - succeeded step

{ "index": { "_index": "gardener-testsuite", "_type": "_doc" } }
{"suite":{"name":"Shoot Test Suite","phase":"Failed","tests":9,"failures":8,"errors":0,"duration":366.86},"name":"[DEFAULT] [RELEASE] [SHOOT] should download shoot kubeconfig successfully","shortName":"[DEFAULT] [RELEASE] [SHOOT] should download shoot kubeconfig successfully","phase":"Succeeded","duration":0.069546686}

using the new reporter - failed step

{"index": { "_index": "gardener-testsuite", "_type": "_doc" } }
{"suite":{"name":"Shoot Test Suite","phase":"Failed","tests":9,"failures":8,"errors":0,"duration":367.428},"name":" [DEFAULT] [SHOOT] should read runtime metrics","shortName":"[DEFAULT] [SHOOT] should read runtime metrics","phase":"Failed","failure":{"type":"Failed","message":"/go/src/github.com/gardener/gardener/test/framework/gingko_utils.go:26\nUnexpected error:\n    \u003c*errors.errorString | 0xc000b8a1a0\u003e: {\n        s: \"could not find template in \\\"/go/src/github.com/gardener/gardener/test/testmachinery/framework/resources/templates/simple-load-deployment.yaml.tpl\\\"\",\n    }\n    could not find template in \"/go/src/github.com/gardener/gardener/test/testmachinery/framework/resources/templates/simple-load-deployment.yaml.tpl\"\noccurred\n/go/src/github.com/gardener/gardener/test/testmachinery/shoots/applications/metrics.go:71"},"duration":10.507470436,"system-out":"[BeforeEach] Shoot application metrics testing..."}

using the deprecated reporter - failed step

{ "index": { "_index": "gardener-testsuite", "_type": "_doc" } }
{"suite":{"name":"Shoot Test Suite","phase":"Failed","tests":9,"failures":8,"errors":0,"duration":366.86},"name":" [DEFAULT] [SHOOT] should read runtime metrics","shortName":"[DEFAULT] [SHOOT] should read runtime metrics","phase":"Failed","failure":{"type":"Failed","message":"/go/src/github.com/gardener/gardener/test/framework/gingko_utils.go:26\nUnexpected error:\n    \u003c*errors.errorString | 0xc000be2f20\u003e: {\n        s: \"could not find template in \\\"/go/src/github.com/gardener/gardener/test/testmachinery/framework/resources/templates/simple-load-deployment.yaml.tpl\\\"\",\n    }\n    could not find template in \"/go/src/github.com/gardener/gardener/test/testmachinery/framework/resources/templates/simple-load-deployment.yaml.tpl\"\noccurred\n/go/src/github.com/gardener/gardener/test/testmachinery/shoots/applications/metrics.go:71"},"duration":10.346779425,"system-out":"[BeforeEach] Shoot application metrics testing..."}

deprecated_report.txt
new_report.txt

[rfranzke]

/invite @acumino

[dguendisch]

Does it make sense to add a unit tests specifically for this reporting (like what you did manually)? Would potentially give us more confidence in future ginkgo updates.

[acumino]

Thanks

/lgtm

[hendrikKahl]

@dguendisch @acumino thanks for your suggestions.

I moved the processing of a ginkgo report to a separate function and added some basic tests for it. This should give us some confidence going forward while avoiding to parse & validate the json dump that is produced for the upload to an elasticsearch instance.

[gardener-robot]

@rfranzke You have pull request review open invite, please check

[dguendisch]

/lgtm

[timebertt]

Thanks @hendrikKahl!