Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote DenyInvalidExtensionResources feature gate to beta #5512

Merged
merged 1 commit into from Mar 7, 2022
Merged

Promote DenyInvalidExtensionResources feature gate to beta #5512

merged 1 commit into from Mar 7, 2022

Conversation

ary1992
Copy link
Contributor

@ary1992 ary1992 commented Mar 4, 2022

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
The DenyInvalidExtensionResources feature gate for seed-admission-controller has been promoted to beta

Special notes for your reviewer:

Release note:

The `DenyInvalidExtensionResources ` feature gate in the `seed-admission-controller` has been promoted to beta and is now enabled by default.

@ary1992 ary1992 requested a review from a team as a code owner March 4, 2022 06:24
@acumino
Copy link
Member

acumino commented Mar 4, 2022

Please set the default value true here also.

gardener/cmd/gardener-seed-admission-controller/app/gardener_seed_admission_controller.go

Line 104 in ab23368

fs.BoolVar(&o.AllowInvalidExtensionResources, "allow-invalid-extension-resources", false, "Allow invalid extension resources")

@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2022
@ary1992
Copy link
Contributor Author

ary1992 commented Mar 4, 2022

Please set the default value true here also.

gardener/cmd/gardener-seed-admission-controller/app/gardener_seed_admission_controller.go

Line 104 in ab23368

fs.BoolVar(&o.AllowInvalidExtensionResources, "allow-invalid-extension-resources", false, "Allow invalid extension resources")

Current feature gate is DenyInvalidExtensionResources which causes the seed-admission-controller to deny invalid extension resources. I think assigning true value to AllowInvalidExtensionResources variable will allow invalid extentions as per the given description. I am bit confused with the chosen flag name and the feature gate name.

@ary1992
Copy link
Contributor Author

ary1992 commented Mar 4, 2022

/retest

@acumino
Copy link
Member

acumino commented Mar 4, 2022

Please set the default value true here also.

gardener/cmd/gardener-seed-admission-controller/app/gardener_seed_admission_controller.go

Line 104 in ab23368

fs.BoolVar(&o.AllowInvalidExtensionResources, "allow-invalid-extension-resources", false, "Allow invalid extension resources")

Current feature gate is DenyInvalidExtensionResources which causes the seed-admission-controller to deny invalid extension resources. I think assigning true value to AllowInvalidExtensionResources variable will allow invalid extentions as per the given description. I am bit confused with the chosen flag name and the feature gate name.

Got It, Its correct only.

rfranzke
rfranzke approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke
Copy link
Member

rfranzke commented Mar 4, 2022

/retest

ialidzhikov
ialidzhikov reviewed Mar 4, 2022
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/invite @stoyanr
as feature gate owner

@gardener-robot
Copy link

@stoyanr You have pull request review open invite, please check

@rfranzke rfranzke merged commit 30ee036 into gardener:master Mar 7, 2022
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@ary1992
Promote DenyInvalidExtensionResources feature gate to beta (gardene…
e021f85 
…r#5512)
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@ary1992
Promote DenyInvalidExtensionResources feature gate to beta (gardene…
99c7183 
…r#5512)
@ary1992 ary1992 deleted the enh/DenyInvalidExtensionResources_Feature branch January 23, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov left review comments

@rfranzke rfranzke rfranzke approved these changes

@stoyanr stoyanr Awaiting requested review from stoyanr

Assignees
No one assigned
Labels
kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ary1992 @acumino @rfranzke @gardener-robot @ialidzhikov @gardener-robot-ci-1 @gardener-robot-ci-2