Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gardener-controller-manager: Remove the audit policy configmap reference protection option #5525

Conversation

ialidzhikov
Copy link
Member

/area control-plane
/kind api-change
/kind cleanup

With this PR it is no longer possible to disable the audit policy configmap reference protection. The field is enabled by default since v1.41 with #5426.

Fixes #5412

Release note:

It is no longer possible to disable the audit policy configmap protection of the Shoot reference controller of gardener-controller-manager. The audit policy configmap protection is enabled by default since v1.41 and was mainly introduced for backwards-compatibility reasons related to the Shoot deletion.

…nce protection option

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested a review from a team as a code owner March 4, 2022 18:16
@gardener-robot gardener-robot added area/control-plane Control plane related kind/api-change API change with impact on API users kind/cleanup Something that is not needed anymore and can be cleaned up needs/review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 4, 2022
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 0cfbb44 into gardener:master Mar 7, 2022
@ialidzhikov ialidzhikov deleted the cleanup/audit-policy-protection-option-2 branch March 9, 2022 07:35
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
…nce protection option (gardener#5525)

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
…nce protection option (gardener#5525)

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related kind/api-change API change with impact on API users kind/cleanup Something that is not needed anymore and can be cleaned up size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gardener-controller-manager: Enable the audit policy configmap reference protection by default
4 participants