add label to cloudprovider secret and adapt webhook #5527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kon-angelo Label kind/scalability does not exist. |
gardener-robot
added
needs/review
size/XS
|
/assign |
rfranzke
requested changes
Mar 7, 2022
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* add label for cloudprovider secret * configure use of objectselector via flag
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* add label for cloudprovider secret * configure use of objectselector via flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
What this PR does / why we need it:
This PR:
a) adds a label to the
cloudprovidersecret deployed on the seeds so that it can be used by webhooksb) updates the clouprovider webhook to use the new label as object selector.
Which issue(s) this PR fixes:
Before the new label the webhook was reacting to all the secrets. In case the extension was not available for some time, the operation of other components e.g. GRM that creates secrets could be halted due to the failing webhook. With this change we should avoid such issues.
Special notes for your reviewer:
Release note: