Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liveness probe to the apiserver-proxy proxy container. #5544

Merged

Conversation

ScheererJ
Copy link
Contributor

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
Add liveness probe to the apiserver-proxy proxy container.

In some rare cases, the proxy containers runs into a busy loop during startup.
The liveness probe should ensure that the container gets restarted after 30 seconds
in case it does not come up properly.

Which issue(s) this PR fixes:
Fixes #5541

Special notes for your reviewer:

Release note:

The proxy container of the apiserver-proxy now has a liveness probe ensuring that failing containers get restarted.

/invite @DockToFuture @timuthy

In some rare cases, the proxy containers runs into a busy loop during startup.
The liveness probe should ensure that the container gets restarted after 30 seconds
in case it does not come up properly.
@ScheererJ ScheererJ requested a review from a team as a code owner March 9, 2022 12:30
@gardener-robot gardener-robot added area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/review labels Mar 9, 2022
@gardener-robot
Copy link

@ScheererJ Thank you for your contribution.

@gardener-robot gardener-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2022
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks a lot for the quick fix.

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @kris94 for the milestone assignment and merge

@krgostev krgostev added this to the v1.42 milestone Mar 9, 2022
@krgostev krgostev merged commit d698bde into gardener:master Mar 9, 2022
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Apiserver-Proxy] Readiness probe fails
8 participants