Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.46] Adjust the path to the shoot CA certificate in the blackbox exporter #5948

Conversation

gardener-ci-robot
Copy link
Contributor

@gardener-ci-robot gardener-ci-robot commented May 11, 2022

This is an automated cherry-pick of #5947

/assign rfranzke

Fix a blackbox exporter configuration issue (path to shoot CA) that resulted in false positive "ApiServerNotReachable" alerts

The blackbox exporter, which is running as a sidecar of the prometheus
in the shoot control plane namespace is used to probe the shoot api server
via its external endpoint. See the red path in the documentation:
https://github.com/gardener/gardener/blob/dc1abd68d3e04679cf810d86086611cbbefa0a66/docs/monitoring/connectivity.md

The TLS connection to the api server does not work which results in
false positive alerts: "ApiServerNotReachable".

The underlying error message is:

```
unable to load specified CA cert /var/run/secrets/shoot-ca/ca.crt:
  open /var/run/secrets/shoot-ca/ca.crt: no such file or directory
```

The blackbox exporter does not have access to the CA certificate that
it needs to verify the certificate of the shoot API server, and hence
the TLS connection fails.

This issue is related to the CA rotation epic, which introduced a different
name for the certificate to support the rotation process.

The path is pointing to this volume:
https://github.com/gardener/gardener/blob/dc1abd68d3e04679cf810d86086611cbbefa0a66/charts/seed-monitoring/charts/core/charts/prometheus/templates/prometheus.yaml#L196
where the file name changed from "ca.crt" to "bundle.crt".

Co-authored-by: Wesley Bermbach <wesley.bermbach@sap.com>
Co-authored-by: Istvan Zoltan Ballok <istvan.zoltan.ballok@sap.com>
@gardener-ci-robot gardener-ci-robot requested a review from a team as a code owner May 11, 2022 07:07
@gardener-prow gardener-prow bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 11, 2022
@gardener-prow gardener-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 11, 2022
@rfranzke
Copy link
Member

/kind regression
/lgtm
/approve

@gardener-prow gardener-prow bot added kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 11, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2022
@gardener-prow gardener-prow bot merged commit 8a1cf99 into gardener:release-v1.46 May 11, 2022
@gardener-ci-robot gardener-ci-robot deleted the cherry-pick-5947-to-release-v1.46 branch January 26, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants