Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.49] Forbid certain rotation operations when Shoot is hibernated #6153

Conversation

gardener-ci-robot
Copy link
Contributor

This is an automated cherry-pick of #6148

/assign rfranzke

It is no longer possible to perform the following shoot operations when it is hibernated: `rotate-{credentials,etcd-encryption-key,serviceaccount-key}-{start,complete}`.

The forbidden rotations require the shoot client since they need to interact with the kube-apiserver. However, when the shoot is hibernated the kube-apiserver is likely not available.
@gardener-prow gardener-prow bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jun 21, 2022
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 21, 2022
@rfranzke
Copy link
Member

/kind bug
/lgtm
/approve

@gardener-prow gardener-prow bot added kind/bug Bug lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 21, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jun 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jun 21, 2022
@gardener-prow gardener-prow bot merged commit e7f0056 into gardener:release-v1.49 Jun 21, 2022
@gardener-ci-robot gardener-ci-robot deleted the cherry-pick-6148-to-release-v1.49 branch January 26, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants