Change default value for --audit-log-path flag of gardener-apiserver … #6204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to /tmp/audit.log Signed-off-by: Vladimir Nachev <vladimir.nachev@sap.com>
gardener-prow
bot
added
size/XS
|
/assign |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
lgtm
I've opened kubernetes/kubernetes#110813 to try to fix this issue. If it is approved and merged, I will also cherry-pick it to the currently support release branches. |
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
…to /tmp/audit.log (gardener#6204) Signed-off-by: Vladimir Nachev <vladimir.nachev@sap.com>
vpnachev
added a commit
to vpnachev/gardener
that referenced
this pull request
Aug 22, 2022
…iserver to /tmp/audit.log (gardener#6204)" This reverts commit c2635e7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind bug
What this PR does / why we need it:
Change default value for --audit-log-path flag of gardener-apiserver to /tmp/audit.log.
Follow up on #6184 as
k8s.io/apiserverexpects the directory of the file to exist, but we cannot expect/tmp/auditto exist in any OCI image. I will try to reproduce and open an issue upstream for this.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
There is an option this issue to be fixed via the Dockerfile, but it is highly specific to the current default path.
@rfranzke please, remove the release notes from #6184 once this is merged.
Release note: