Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip-health-check annotation for managed resources #6309

Merged
merged 7 commits into from
Jul 15, 2022

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Jul 13, 2022

How to categorize this PR?

/area usability
/kind enhancement

What this PR does / why we need it:
This PR introduces an annotation resources.gardener.cloud/skip-health-check. If this annotation is set to true, then resource-manager will skip health check for this resource, and ResourcesHealthy for the MR would be True even if this resource is unhealthy. Also the ResourcesProgressing condition will be set to False even if the resource hasn't been fully rolled out yet (In case of statefulsets, deployments and daemonsets).

This annotation has been set to true for reserve-excess-capacity deployment by default, so that the seed can get Ready even if this pod is stuck in pending.

Which issue(s) this PR fixes:
Fixes #6275

Special notes for your reviewer:

Release note:

If a resource in the `ManagedResource` is annotated with `resources.gardener.cloud/skip-health-check=true` then the resource will be skipped during health checks by the health controller. The ManagedResource conditions will not reflect the health condition of this resource anymore. The `ResourcesProgressing` condition will also be set to `False`.

@gardener-prow gardener-prow bot added area/usability Usability related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jul 13, 2022
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 13, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 13, 2022

@shafeeqes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-apidiff fe9719d link false /test pull-gardener-apidiff

Full PR test history. Your PR dashboard. Command help for this repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ary1992
Copy link
Contributor

ary1992 commented Jul 13, 2022

/assign

@ary1992
Copy link
Contributor

ary1992 commented Jul 14, 2022

Thanks for the PR :)
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2022
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, well structured!
/lgtm

@rfranzke
Copy link
Member

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2022
@gardener-prow gardener-prow bot merged commit 0c3b536 into gardener:master Jul 15, 2022
@shafeeqes shafeeqes deleted the enh/skip-health-check branch July 22, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pending reserve-excess-capacity pods cause seed as notReady
3 participants