-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skip-health-check
annotation for managed resources
#6309
Add skip-health-check
annotation for managed resources
#6309
Conversation
6124eb1
to
fe9719d
Compare
@shafeeqes: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign |
Thanks for the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR, well structured!
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area usability
/kind enhancement
What this PR does / why we need it:
This PR introduces an annotation
resources.gardener.cloud/skip-health-check
. If this annotation is set to true, thenresource-manager
will skip health check for this resource, andResourcesHealthy
for the MR would beTrue
even if this resource is unhealthy. Also theResourcesProgressing
condition will be set toFalse
even if the resource hasn't been fully rolled out yet (In case of statefulsets, deployments and daemonsets).This annotation has been set to true for
reserve-excess-capacity
deployment by default, so that the seed can getReady
even if this pod is stuck in pending.Which issue(s) this PR fixes:
Fixes #6275
Special notes for your reviewer:
Release note: