Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tools download for aarch64 (arm64) 馃惂 #6314

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Jul 13, 2022

How to categorize this PR?

/area dev-productivity
/kind bug

What this PR does / why we need it:
This PR fixes the tools download procedure for ARM64 based Linux machines.

Special notes for your reviewer:

Darwin Output:

> uname -m
arm64

Linux Output:

$ uname -m
aarch64

Release note:

Downloading several tools vial `./hack/tools.mk` has been fixed for ARM64 based Linux machines.

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jul 13, 2022
@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 13, 2022
@timuthy timuthy changed the title Fix tools download for aarch64 (arm64) Fix tools download for aarch64 (arm64) 馃惂 Jul 13, 2022
@oliver-goetz
Copy link
Member

oliver-goetz commented Jul 13, 2022

/lgtm
/retest

I added the issue you created for the missing docforge binary to our ARM umbrella issue #6258

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
@rfranzke
Copy link
Member

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@gardener-prow gardener-prow bot merged commit 94a57bb into gardener:master Jul 13, 2022
@timuthy timuthy deleted the enhancement.local-setup branch July 14, 2022 07:00
krgostev pushed a commit to krgostev/gardener that referenced this pull request Sep 8, 2022
* 'master' of github.com:gardener/gardener: (51 commits)
  Switch extension controller to `logr` and streamline/cleanup logs (gardener#6332)
  Switch `./test/...` packages to `logr` and drop `github.com/sirupsen/logrus` dependency (gardener#6316)
  Only check shoot conditions during hibernation integration test (gardener#6325)
  Add dashboard for monitoring conntrack race failures. (gardener#6329)
  Reconcile quota before rbac (gardener#6326)
  Update istio to v1.14.1 (gardener#6271)
  Update gardenlet's base image to alpine:3.16.0 (gardener#6321)
  Update envoy proxy to v1.21.4 (gardener#6320)
  Deploy the metrics server to the kind cluster (gardener#6301)
  Fix tools download for aarch64 (arm64) (gardener#6314)
  update with latest CA releases (gardener#6295)
  Add missing unit tests for the predicates provided by the extensions library (gardener#6249)
  [GEP-19] Monitoring Stack - Migrating to the `prometheus-operator` (gardener#6151)
  Revert "Recreate DWD deployment if needed" (gardener#6307)
  Update to golang 1.18.4 (gardener#6300)
  Cleaned up imports in vpn-seed-server (gardener#6315)
  Prepare next Dev Cycle v1.52.0-dev
  Release v1.51.0
  Add pre/post reconciliation/deletion hooks for the Worker resource (gardener#6290)
  Update the supported values in the usage text of the `--leader-election-resource-lock` flag (gardener#6304)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants