-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve default machine image selection for worker pool having machine of CPU architecture arm64
#6324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve default image selection for arm worker pool.
Can you elaborate in the PR description which case exactly gets improved and how? Doesn't this PR deserve a release note?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one main goal of the issue was to provide helpful error messages in case a machine image or type is selected which does not match the architecture
in the worker pool, something like this:
gardener/plugin/pkg/shoot/validator/admission.go
Line 1244 in 8a6dce8
detail := fmt.Sprintf("machine image '%s@%s' does not support container runtime '%s', supported values: %+v", worker.Machine.Image.Name, worker.Machine.Image.Version, cr.Type, validValues) |
Is this achieved?
What is this PR doing actually? The PR description is pretty poor.
3334640
to
36f6ed9
Compare
arm64
36f6ed9
to
e48e4f7
Compare
/assign @shafeeqes @rfranzke |
Can you add a release note stating that the machine image defaulting does now work based on the CPU architecture? |
e48e4f7
to
8c50e31
Compare
8c50e31
to
144904a
Compare
Thanks, tested the changes locally and it works as expected. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area delivery
/kind enhancement
What this PR does / why we need it:
This PR improves default machine image selection for worker pool having machine of CPU architecture
arm64
. Also improves the validation message for machine type and machine image of shoot.Which issue(s) this PR fixes:
Part of https://github.com/gardener/backlog/issues/19
Special notes for your reviewer:
/cc @rfranzke
Release note: