Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default machine image selection for worker pool having machine of CPU architecture arm64 #6324

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

acumino
Copy link
Member

@acumino acumino commented Jul 14, 2022

How to categorize this PR?

/area delivery
/kind enhancement

What this PR does / why we need it:
This PR improves default machine image selection for worker pool having machine of CPU architecture arm64. Also improves the validation message for machine type and machine image of shoot.

Which issue(s) this PR fixes:
Part of https://github.com/gardener/backlog/issues/19

Special notes for your reviewer:
/cc @rfranzke

Release note:

The machine image defaulting does now work based on the CPU architecture of the machine in a given worker pool.

@acumino acumino requested a review from rfranzke July 14, 2022 10:15
@gardener-prow gardener-prow bot added area/delivery Delivery related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2022
@acumino acumino changed the title Improve deafult machine image selection Improve default machine image selection Jul 14, 2022
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve default image selection for arm worker pool.

Can you elaborate in the PR description which case exactly gets improved and how? Doesn't this PR deserve a release note?

plugin/pkg/shoot/validator/admission.go Outdated Show resolved Hide resolved
plugin/pkg/shoot/validator/admission.go Show resolved Hide resolved
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one main goal of the issue was to provide helpful error messages in case a machine image or type is selected which does not match the architecture in the worker pool, something like this:

detail := fmt.Sprintf("machine image '%s@%s' does not support container runtime '%s', supported values: %+v", worker.Machine.Image.Name, worker.Machine.Image.Version, cr.Type, validValues)

Is this achieved?
What is this PR doing actually? The PR description is pretty poor.

@acumino acumino changed the title Improve default machine image selection Improve default machine image selection for worker pool having machine of CPU architecture arm64 Jul 18, 2022
@gardener-prow gardener-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2022
plugin/pkg/shoot/validator/admission.go Outdated Show resolved Hide resolved
plugin/pkg/shoot/validator/admission.go Outdated Show resolved Hide resolved
@rfranzke
Copy link
Member

/assign @shafeeqes @rfranzke

@rfranzke
Copy link
Member

Can you add a release note stating that the machine image defaulting does now work based on the CPU architecture?

plugin/pkg/shoot/validator/admission.go Outdated Show resolved Hide resolved
plugin/pkg/shoot/validator/admission.go Outdated Show resolved Hide resolved
plugin/pkg/shoot/validator/admission.go Outdated Show resolved Hide resolved
plugin/pkg/shoot/validator/admission_test.go Outdated Show resolved Hide resolved
@shafeeqes
Copy link
Contributor

Thanks, tested the changes locally and it works as expected.
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@rfranzke
Copy link
Member

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
@gardener-prow gardener-prow bot merged commit 04215ca into gardener:master Jul 20, 2022
@acumino acumino deleted the improve/validation branch November 21, 2022 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/delivery Delivery related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants