-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cluster autoscaler permissions #6372
Fix cluster autoscaler permissions #6372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for the changes, I also think a role seperately for kube-system is better.
I have a concern/doubt though, upstream I see they still have configmap rules in ClusterRole. Maybe they forgot to update it
@himanshu-kun: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/operation/botanist/component/clusterautoscaler/cluster_autoscaler.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: himanshu-kun, ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area auto-scaling
/kind bug
What this PR does / why we need it
Adjust permissions for cluster-autoscaler, such that we don't see any error messages anymore and we can make use of
expander: priority
. At the same time, I reduced the scope of permissions for ConfigMaps, as the cluster-autoscaler only needs access to thekube-system
namespace.Which issue(s) this PR fixes:
Fixes #6370
Release note: