Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster autoscaler permissions #6372

Merged

Conversation

voelzmo
Copy link
Member

@voelzmo voelzmo commented Jul 21, 2022

How to categorize this PR?

/area auto-scaling
/kind bug

What this PR does / why we need it
Adjust permissions for cluster-autoscaler, such that we don't see any error messages anymore and we can make use of expander: priority. At the same time, I reduced the scope of permissions for ConfigMaps, as the cluster-autoscaler only needs access to the kube-system namespace.

Which issue(s) this PR fixes:
Fixes #6370

Release note:

Fixed a bug that prevented Shoots from being able to use `expander: priority` for cluster-autoscaler

@gardener-prow gardener-prow bot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jul 21, 2022
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 21, 2022
@ialidzhikov ialidzhikov self-assigned this Jul 21, 2022
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for the changes, I also think a role seperately for kube-system is better.
I have a concern/doubt though, upstream I see they still have configmap rules in ClusterRole. Maybe they forgot to update it

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 21, 2022

@himanshu-kun: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm
Thanks for the changes, I also think a role seperately for kube-system is better.
I have a concern/doubt though, upstream I see they still have configmap rules in ClusterRole. Maybe they forgot to update it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: himanshu-kun, ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2022
@gardener-prow gardener-prow bot merged commit 6fc3bb0 into gardener:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster-autoscaler missing permissions for configmaps: expander type priority not usable
3 participants