Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller-manager] Switch Quota controller to controller-runtime #6391

Merged
merged 6 commits into from
Aug 1, 2022
Merged

[controller-manager] Switch Quota controller to controller-runtime #6391

merged 6 commits into from
Aug 1, 2022

Conversation

ary1992
Copy link
Contributor

@ary1992 ary1992 commented Jul 25, 2022 •
edited
Loading

How to categorize this PR?

/area dev-productivity scalability
/kind enhancement

What this PR does / why we need it:
Refactor the Quota controller to controller-runtime.

Which issue(s) this PR fixes:
Part of #4251

Special notes for your reviewer:
Adapting integration test as per #6398

Release note:

NONE

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) area/scalability Scalability related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jul 25, 2022
@gardener-prow gardener-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 25, 2022
@ary1992 ary1992 changed the title Refactor/quota ctrl Switch Quota controller to controller-runtime Jul 25, 2022
@acumino acumino self-assigned this Jul 25, 2022
@ary1992 ary1992 mentioned this pull request Jul 25, 2022
Closed
76 tasks
acumino
acumino reviewed Jul 26, 2022
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
/lgtm

pkg/controllermanager/controller/quota/quota_suite_test.go Outdated Show resolved Hide resolved
test/integration/controllermanager/quota/quota_test.go Outdated Show resolved Hide resolved
@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
acumino
acumino reviewed Jul 26, 2022
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@acumino acumino removed their assignment Jul 26, 2022
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@rfranzke
Copy link
Member

/assign

plkokanov
plkokanov requested changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a joint review on the PR @oliver-goetz

docs/concepts/controller-manager.md Outdated Show resolved Hide resolved
pkg/controllermanager/controller/add.go Outdated Show resolved Hide resolved
pkg/controllermanager/controller/quota/add.go Outdated Show resolved Hide resolved
pkg/controllermanager/controller/quota/reconciler.go Outdated Show resolved Hide resolved
docs/concepts/controller-manager.md Outdated Show resolved Hide resolved
test/integration/controllermanager/quota/quota_suite_test.go Outdated Show resolved Hide resolved
test/integration/controllermanager/quota/quota_test.go Outdated Show resolved Hide resolved
rfranzke
rfranzke requested changes Jul 26, 2022
View reviewed changes
test/integration/controllermanager/quota/quota_suite_test.go Outdated Show resolved Hide resolved
test/integration/controllermanager/quota/quota_test.go Outdated Show resolved Hide resolved
test/integration/controllermanager/quota/quota_test.go Outdated Show resolved Hide resolved
test/integration/controllermanager/quota/quota_test.go Outdated Show resolved Hide resolved
test/integration/controllermanager/quota/quota_test.go Outdated Show resolved Hide resolved
test/integration/controllermanager/quota/quota_test.go Outdated Show resolved Hide resolved
test/integration/controllermanager/quota/quota_test.go Outdated Show resolved Hide resolved
pkg/controllermanager/controller/quota/reconciler_test.go Outdated Show resolved Hide resolved
test/integration/controllermanager/quota/quota_suite_test.go Show resolved Hide resolved
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2022
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2022
@rfranzke
Copy link
Member

/unassign @rfranzke

istvanballok
istvanballok reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@istvanballok istvanballok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit

pkg/controllermanager/controller/quota/quota_suite_test.go Outdated Show resolved Hide resolved
@ary1992 ary1992 requested a review from plkokanov July 29, 2022 06:13
@shafeeqes shafeeqes requested a review from acumino July 29, 2022 06:56
@timebertt
Copy link
Member

/assign

timebertt
timebertt reviewed Jul 29, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Generally lgtm, just two nits

docs/concepts/controller-manager.md Outdated Show resolved Hide resolved
test/integration/controllermanager/quota/quota_test.go Outdated Show resolved Hide resolved
@ary1992 ary1992 requested a review from timebertt July 29, 2022 10:21
@acumino acumino added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 31, 2022
@shafeeqes
Copy link
Contributor

/retest

timebertt
timebertt approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@gardener-prow gardener-prow bot merged commit 29c8327 into gardener:master Aug 1, 2022
@ary1992 ary1992 deleted the refactor/quota-ctrl branch August 1, 2022 11:22
@rfranzke rfranzke changed the title Switch Quota controller to controller-runtime Switch Quota controller to controller-runtime Sep 1, 2022
krgostev pushed a commit to krgostev/gardener that referenced this pull request Sep 8, 2022
Merge branch 'master' of github.com:gardener/gardener into master
879822b 
* 'master' of github.com:gardener/gardener: (83 commits)
  Option to disable gardener shoot monitoring (gardener#6433)
  Switch ExposureClass controller to controller-runtime (gardener#6423)
  Exclude the proxy subresource from the KubeApiServerLatency alert and dashboard (gardener#6445)
  Collect filesystem metrics for the /run tmpfs mount point (gardener#6424)
  update CA image in charts for 1.22,1.21 and 1.20 (gardener#6449)
  Update redis test image to multi arch image (gardener#6446)
  Promote the `SecretBindingProviderValidation` feature gate to GA (gardener#6429)
  Upgrade K8s dependencies to v0.24.3 (gardener#6443)
  Enhance etcd readiness check (gardener#6434)
  Disables owner checks for clustered etcd (gardener#6412)
  Upgrade gardener/autoscaler (gardener#6428)
  Streamline integration tests (gardener#6398)
  Revert "Adapt `gardenlet` to use priority class `gardener-system-critical` (gardener#6235)"  (gardener#6432)
  Improve validations on `shoots/binding` update (gardener#6416)
  Enforce that Shoot nginx-ingress addon and Seed VPA are not enabled for ManagedSeeds (gardener#6388)
  Switch Quota controller to controller-runtime (gardener#6391)
  Use multi-arch node-problem-detector image (gardener#6415)
  Reload kube-apiserver variable on dashboard time change (gardener#6407)
  [GRM] Label managed resources (gardener#6393)
  Adapt seed system components priority classes (gardener#6257)
  ...
@rfranzke rfranzke changed the title Switch Quota controller to controller-runtime [controller-manager] Switch Quota controller to controller-runtime Sep 23, 2022
@rfranzke rfranzke changed the title [controller-manager] Switch Quota controller to controller-runtime [controller-manager] Switch Quota controller to controller-runtime Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istvanballok istvanballok istvanballok left review comments

@timebertt timebertt timebertt approved these changes

@abdasgupta abdasgupta Awaiting requested review from abdasgupta

@rfranzke rfranzke Awaiting requested review from rfranzke

@plkokanov plkokanov Awaiting requested review from plkokanov

@acumino acumino Awaiting requested review from acumino

Assignees

@plkokanov plkokanov

@timebertt timebertt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) area/scalability Scalability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ary1992 @rfranzke @timebertt @shafeeqes @istvanballok @acumino @plkokanov