Prevent panic in gardenlet when shoot namespace doesn't have required project label #6408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
gardener-prow
bot
added
do-not-merge/work-in-progress
|
/test all |
gardener-prow
bot
added
the
size/L
shafeeqes
reviewed
Jul 28, 2022
gardener-prow
bot
removed
the
do-not-merge/work-in-progress
|
/milestone v1.52 |
|
/invite @ialidzhikov |
timebertt
reviewed
Jul 28, 2022
ialidzhikov
reviewed
Jul 28, 2022
gardener-prow
bot
added
size/XS
ialidzhikov
reviewed
Jul 28, 2022
Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
gardener-prow
bot
added
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind bug
What this PR does / why we need it:
Before #4040 we used
ProjectForNamespaceFromReaderwhich returns anerrorif the project is not found but with #4040 we switched it toProjectAndNamespaceFromReaderwhich if the project is not found doesn't return an error and the project is set to nil. Which causes panic in gardenlet because it tries to fetch the project name from nil value.Which issue(s) this PR fixes:
Fixes #6286
Special notes for your reviewer:
Release note: