Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CRD for DNSEntries to allow specifying routing policy #6414

Merged

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
The dns-controller-manager will support weighted routing policy with the next release.
The CustomResourceDefinition for dnsentries.dns.gardener.cloud are still managed by the Gardenlet on the seeds, so it needs to be updated.

Special notes for your reviewer:
See PR gardener/external-dns-management#270

Release note:

Updating CRD for `DNSEntries` to allow specifying routing policy

@gardener-prow gardener-prow bot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension labels Jul 28, 2022
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2022
@rfranzke
Copy link
Member

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@rfranzke
Copy link
Member

/unassign @rfranzke

@MartinWeindel
Copy link
Member Author

@acumino Can you add this PR to v1.52 please?

@acumino
Copy link
Member

acumino commented Jul 29, 2022

@acumino Can you add this PR to v1.52 please?

Done.
/milestone v1.52

@gardener-prow gardener-prow bot added this to the v1.52 milestone Jul 29, 2022
@acumino acumino added area/dev-productivity Developer productivity related (how to improve development) and removed area/dev-productivity Developer productivity related (how to improve development) labels Jul 29, 2022
@gardener-prow gardener-prow bot merged commit c4a0b3e into gardener:master Jul 29, 2022
@MartinWeindel MartinWeindel deleted the dnsentry-weighted-routing branch October 21, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants