Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller-manager] Switch ControllerDeployment controller to controller-runtime #6462

Merged
merged 4 commits into from
Aug 11, 2022
Merged

[controller-manager] Switch ControllerDeployment controller to controller-runtime #6462

merged 4 commits into from
Aug 11, 2022

Conversation

ary1992
Copy link
Contributor

@ary1992 ary1992 commented Aug 8, 2022

How to categorize this PR?

/area dev-productivity scalability
/kind enhancement

What this PR does / why we need it:
Refactor the ControllerDeployment controller to controller-runtime.

Which issue(s) this PR fixes:
Part of #4251

Release note:

NONE

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) area/scalability Scalability related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Aug 8, 2022
@gardener-prow gardener-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 8, 2022
@ary1992 ary1992 mentioned this pull request Aug 8, 2022
Closed
76 tasks
@ary1992 ary1992 force-pushed the refactor/controllerdeployment-ctrl branch from 2975825 to 825c386 Compare August 8, 2022 11:48
@ary1992
Copy link
Contributor Author

ary1992 commented Aug 8, 2022

/test pull-gardener-e2e-kind

timebertt
timebertt reviewed Aug 9, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a joint review with @kris94, this looks pretty good already :)

test/integration/controllermanager/controllerdeployment/controllerdeployment_suite_test.go Outdated Show resolved Hide resolved
pkg/controllermanager/controller/controllerdeployment/add.go Outdated Show resolved Hide resolved
pkg/controllermanager/controller/controllerdeployment/reconciler_test.go Outdated Show resolved Hide resolved
pkg/controllermanager/controller/controllerdeployment/reconciler_test.go Outdated Show resolved Hide resolved
@ary1992 ary1992 requested a review from timebertt August 9, 2022 12:05
timebertt
timebertt approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Aug 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@timebertt
Copy link
Member

/hold
blocking tide's merge pool

@gardener-prow gardener-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2022
@timebertt
Copy link
Member

/hold cancel

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2022
@gardener-prow gardener-prow bot merged commit 513acfb into gardener:master Aug 11, 2022
@rfranzke rfranzke changed the title Switch ControllerDeployment controller to controller-runtime Switch ControllerDeployment controller to controller-runtime Sep 1, 2022
@rfranzke rfranzke changed the title Switch ControllerDeployment controller to controller-runtime [controller-manager] Switch ControllerDeployment controller to controller-runtime Sep 23, 2022
@rfranzke rfranzke changed the title [controller-manager] Switch ControllerDeployment controller to controller-runtime [controller-manager] Switch ControllerDeployment controller to controller-runtime Dec 14, 2022
@ary1992 ary1992 deleted the refactor/controllerdeployment-ctrl branch February 16, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt approved these changes

@acumino acumino Awaiting requested review from acumino

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

Assignees

@timebertt timebertt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) area/scalability Scalability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ary1992 @timebertt