-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup CloudProfile docker migration and Add Validation MachineImageVersion CRI #6480
Conversation
/test pull-gardener-e2e-kind |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care!
Generally lgtm, just a few nits
@acumino: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area control-plane
/kind cleanup
What this PR does / why we need it:
This PR adds validation for the CloudProfile MachineImageVersion CRI field. Now
spec.machineImages[].versions[].cri
in CloudProfile can't be set to nil. Alsodocker
is added by default incri
. This defaulting of docker incri
can be removed after completion of #4673.Which issue(s) this PR fixes:
Fixes #6375
Cleanup of left-overs / unfinished work from #4110 (ref #4501)
Special notes for your reviewer:
Release note: