Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label shoots for globally enabled extensions #6534

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area robustness
/kind bug

What this PR does / why we need it:

Label shoots for globally enabled extensions, which was missing in #5472.

Which issue(s) this PR fixes:
Fixes #6528
xref #4932

Special notes for your reviewer:

cc @shafeeqes @MartinWeindel

Release note:

Shoots are correctly labeled for globally enabled extensions now.

@gardener-prow gardener-prow bot added area/robustness Robustness, reliability, resilience related kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Aug 19, 2022
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2022
@timebertt
Copy link
Member Author

/cherrypick release-v1.53

@gardener-ci-robot
Copy link
Contributor

@timebertt: once the present PR merges, I will cherry-pick it on top of release-v1.53 in a new PR and assign it to you.

In response to this:

/cherrypick release-v1.53

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timebertt
Copy link
Member Author

/cherrypick release-v1.52

@gardener-ci-robot
Copy link
Contributor

@timebertt: once the present PR merges, I will cherry-pick it on top of release-v1.52 in a new PR and assign it to you.

In response to this:

/cherrypick release-v1.52

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timebertt
Copy link
Member Author

/cherrypick release-v1.51

@gardener-ci-robot
Copy link
Contributor

@timebertt: once the present PR merges, I will cherry-pick it on top of release-v1.51 in a new PR and assign it to you.

In response to this:

/cherrypick release-v1.51

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Aug 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shafeeqes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2022
@gardener-prow gardener-prow bot merged commit 3ed9a0e into gardener:master Aug 19, 2022
@gardener-ci-robot
Copy link
Contributor

@timebertt: new pull request created: #6536

In response to this:

/cherrypick release-v1.53

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-ci-robot
Copy link
Contributor

@timebertt: new pull request created: #6537

In response to this:

/cherrypick release-v1.52

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gardener-ci-robot
Copy link
Contributor

@timebertt: new pull request created: #6538

In response to this:

/cherrypick release-v1.51

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timebertt timebertt deleted the label-globally-enabled branch August 19, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/robustness Robustness, reliability, resilience related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shoots are not labelled for globally enabled extensions
3 participants