Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller-manager] Switch Event controller to controller-runtime #6550

Merged
merged 5 commits into from
Aug 23, 2022
Merged

[controller-manager] Switch Event controller to controller-runtime #6550

merged 5 commits into from
Aug 23, 2022

Conversation

ary1992
Copy link
Contributor

@ary1992 ary1992 commented Aug 22, 2022

How to categorize this PR?

/area dev-productivity scalability
/kind enhancement

What this PR does / why we need it:
Refactor the Event controller to controller-runtime.

Which issue(s) this PR fixes:
Part of #4251

Special notes for your reviewer:

Release note:

NONE

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) area/scalability Scalability related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Aug 22, 2022
@gardener-prow gardener-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 22, 2022
@ary1992 ary1992 mentioned this pull request Aug 22, 2022
Closed
76 tasks
@timebertt
Copy link
Member

/assign

timebertt
timebertt reviewed Aug 22, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I have some suggestions for simplification :)

test/integration/controllermanager/event/event_test.go Outdated Show resolved Hide resolved
test/integration/controllermanager/event/event_test.go Outdated Show resolved Hide resolved
pkg/controllermanager/controller/event/reconciler.go Outdated Show resolved Hide resolved
pkg/controllermanager/controller/event/reconciler_test.go Outdated Show resolved Hide resolved
@ary1992 ary1992 requested a review from timebertt August 22, 2022 12:48
@ary1992 ary1992 force-pushed the refactor/event-ctrl branch 2 times, most recently from d1a6916 to eaf275a Compare August 23, 2022 06:50
@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Aug 23, 2022
timebertt
timebertt reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my suggestions, this looks much more readable now :)
One remaining nit

test/integration/controllermanager/event/event_suite_test.go Outdated Show resolved Hide resolved
@ary1992 ary1992 requested a review from timebertt August 23, 2022 10:48
timebertt
timebertt approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@gardener-prow gardener-prow bot merged commit 195189a into gardener:master Aug 23, 2022
shafeeqes pushed a commit to shafeeqes/gardener that referenced this pull request Aug 24, 2022
@ary1992 @shafeeqes
Switch Event controller to controller-runtime (gardener#6550)
bf14831 
* Enhance documentation

* Add integration test

* Switch controller to native controller-runtime controller

* [PR feedback] use clock.Clock in the controller

* Address PR review feedback
@rfranzke rfranzke changed the title Switch Event controller to controller-runtime Switch Event controller to controller-runtime Sep 1, 2022
@rfranzke rfranzke changed the title Switch Event controller to controller-runtime [controller-manager] Switch Event controller to controller-runtime Sep 23, 2022
@rfranzke rfranzke changed the title [controller-manager] Switch Event controller to controller-runtime [controller-manager] Switch Event controller to controller-runtime Dec 14, 2022
@ary1992 ary1992 deleted the refactor/event-ctrl branch February 16, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt approved these changes

@plkokanov plkokanov Awaiting requested review from plkokanov

@shafeeqes shafeeqes Awaiting requested review from shafeeqes

Assignees

@timebertt timebertt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) area/scalability Scalability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ary1992 @timebertt