[controller-manager] Switch SecretBinding controller to controller-runtime
#6621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
76 tasks
gardener-prow
bot
added
the
size/XL
shafeeqes
reviewed
Sep 5, 2022
pkg/controllermanager/controller/secretbinding/secretbinding_control.go
Outdated
Show resolved
Hide resolved
gardener-prow
bot
added
the
needs-rebase
rfranzke
force-pushed
the
refactor/secretbinding-ctrl
branch
from
a8ceeb0
to
3f9d385
Compare
gardener-prow
bot
removed
the
needs-rebase
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
|
/skip |
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Sep 8, 2022
* 'master' of github.com:gardener/gardener: (121 commits) Added metrics needed for multi-node etcd and backup-restore. (gardener#6601) Fix beta failing test for arm (gardener#6632) Install yq in e2e CI jobs (gardener#6631) Upgrade etcd-druid (gardener#6630) Switch `SecretBinding` controller to `controller-runtime` (gardener#6621) Fix the network metrics for clusters with containerd (gardener#6628) Remove release milestone github action (gardener#6627) Adds `Progressing` status to `BackupBucketsReady` seed condition (gardener#6587) Adds more info when comparing secrets for cpm integration tests (gardener#6622) Update profiling docs (gardener#6624) Add `Progressing` condition type to `ControllerInstallations` and check it when computing the `ExtensionsReady` condition (gardener#6590) Deny setting `.spec.kubernetes.allowPrivilegedContainers` field for Shoot clusters `>=v1.25` (gardener#6570) Use v3.24.1 manifests for calico (gardener#6616) Exempt `kube-system` namespace in `PodSecurity` admission config (gardener#6549) Make sure the `default-scheduler` is present even when bin-packing is enabled (gardener#6610) Upgrade etcd-druid (gardener#6611) Adapt blackbox exporter resource requests to VPA recommendations (gardener#6609) Clean up unused search textbox in the `Kubernetes Control Plane Status` dashboard (gardener#6606) Reduce the size of the grafana dashboards configmap (gardener#6605) Fix bug in resourcemanager that ignore annotation does handle all possible truthy values (gardener#6603) ...
rfranzke
changed the title
SecretBinding controller to controller-runtimeSecretBinding controller to controller-runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity scalability
/kind enhancement
What this PR does / why we need it:
Refactor the
SecretBindingcontroller tocontroller-runtime.Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer:
Generally, we want to follow this cookbook while refactoring existing controllers:
envtestcontroller-runtimeRelease note: