[controller-manager] Switch ControllerRegistration controller to controller-runtime
#6629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
76 tasks
gardener-prow
bot
added
the
size/XXL
|
/assign |
ary1992
reviewed
Sep 8, 2022
There was a problem hiding this comment.
Thank you for the PR. Had a great learning experience while reviewing the PR along with @oliver-goetz . Just have few minor comments.
test/integration/controllermanager/controllerregistration/controllerregistration_suite_test.go
Show resolved
Hide resolved
test/integration/controllermanager/controllerregistration/controllerregistration_test.go
Outdated
Show resolved
Hide resolved
...ontrollermanager/controller/controllerregistration/seedfinalizer/seedfinalizer_suite_test.go
Outdated
Show resolved
Hide resolved
...erregistration/controllerregistrationfinalizer/controllerregistrationfinalizer_suite_test.go
Outdated
Show resolved
Hide resolved
pkg/controllermanager/controller/controllerregistration/seed/add_test.go
Show resolved
Hide resolved
…er-runtime controller
For now, only the watches for the Seeds and ControllerRegistrations are added. Those were part of event handler functions removed in the previous two commits. The other event handlers will be refactored in the subsequent commits to ease the review process.
rfranzke
force-pushed
the
refactor/ctrlreg-ctrl
branch
from
30ec5c1
to
6f34b45
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
rfranzke
changed the title
ControllerRegistration controller to controller-runtimeControllerRegistration controller to controller-runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity scalability
/kind enhancement
What this PR does / why we need it:
Refactor the
ControllerRegistrationcontroller tocontroller-runtime.Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer:
Generally, we want to follow this cookbook while refactoring existing controllers:
envtestcontroller-runtimeRelease note: