[controller-manager] Switch main Project controller to controller-runtime
#6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/dev-productivity
gardener-prow
bot
added
size/XXL
|
I stress-tested the new integration test a bit to hopefully not introduce the next flaky test: |
76 tasks
timebertt
force-pushed
the
refactor-project-controller
branch
2 times, most recently
from
8a13cd7
to
54f1856
Compare
|
I dropped 8a13cd7 again, because it prevents |
acumino
reviewed
Sep 8, 2022
|
/assign |
rfranzke
reviewed
Sep 11, 2022
ClusterRole aggregration only works with a running kube-controller-manager, thus it doesn't work in envtest. One way to test it, would be to mimic the controller. However, we have a proper setup for executing tests against a full-fledged cluster (e2e tests), so rather use this one instead. This makes sure, that the extension roles mechanism actually works e2e.
- only perform deletion action if gardener finalizer is still present - watch namespace to immediately release the project once its namespace is gone
Also, don't ignore errors when patching status
rfranzke
force-pushed
the
refactor-project-controller
branch
from
27bd019
to
6b391f6
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
|
/test pull-gardener-integration |
rfranzke
changed the title
Project controller to controller-runtimeProject controller to controller-runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity scalability
/kind enhancement
What this PR does / why we need it:
Projectcontroller tocontroller-runtime.Projectcontrollerv0.12.3Which issue(s) this PR fixes:
Part of #4251
Special notes for your reviewer:
Release note: